This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE: Minimally test every non-startup module.
Type: behavior Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: 33917 Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, miss-islington, taleinat, terry.reedy
Priority: normal Keywords: patch

Created on 2018-06-14 07:13 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7689 merged terry.reedy, 2018-06-14 07:20
PR 7731 merged miss-islington, 2018-06-15 22:22
PR 7734 merged terry.reedy, 2018-06-15 22:51
PR 7761 merged terry.reedy, 2018-06-17 06:55
PR 7774 merged miss-islington, 2018-06-18 08:49
PR 7775 merged miss-islington, 2018-06-18 08:50
PR 7784 merged terry.reedy, 2018-06-19 04:00
PR 7805 merged miss-islington, 2018-06-19 23:14
PR 7806 merged miss-islington, 2018-06-19 23:15
Messages (16)
msg319501 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-14 07:13
For module in idlelib modules:
    Create test_module from new template.py.
    Add 'module' to docstring and import.
    Check other minimal imports.
    Create instance of each class, with requires('gui') if needed.
    Add initial coverage of this test.

I am also reviewing existing tests.

PR initially adds template, 1 new file, and edits 3 others.  Needs blurb.   I will add more, but will likely break this up into multiple PRs.  This should, of course, been done years ago.

Reviews welcome, non-Windows test would be good.  (Tal, what do you have?)
msg319506 - (view) Author: Tal Einat (taleinat) * (Python committer) Date: 2018-06-14 10:17
My main laptop is currently Windows 10, I use it for most CPython work.

I also have PCs running OSX, Ubuntu and Windows 7.

Terry, let me know what and when you'd like me to run on which OSs, and I'll get it done :)
msg319668 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-15 20:38
debugger and debugger_r: tests are subminimal because instantiating classes is not trivial.
dynoption: skipped because I expect it will be replaced and deleted when I review PR to do so.
editor: I discovered, or rediscovered, a new shutdown issue, with EditorWindow.  It appeared in the new test_flist also.  This time, I discovered how to solve it with tcl after info, thanks to Cheryl using it for test_codecontext.
---
I am going to break this into 3 PRs.  The first third is done.  Having written this much, I think the new code is very unlikely to break on other OSes, so I don't think special testing is necessary before merging.

Tal, if you have a cpython clone on your OSX machine, it would be nice to have "python -m test.test_idle" (which runs gui tests) run in an updated repository at least once a week if there is anything new.
msg319683 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-15 22:20
New changeset ee5ef309c7e2daef1248730145408f700732c42e by Terry Jan Reedy in branch 'master':
bpo-33855: Minimally test all IDLE modules. (GH-7689)
https://github.com/python/cpython/commit/ee5ef309c7e2daef1248730145408f700732c42e
msg319687 - (view) Author: miss-islington (miss-islington) Date: 2018-06-15 22:38
New changeset 508568764593dca3844a51c10f1493413a51d66f by Miss Islington (bot) in branch '3.7':
bpo-33855: Minimally test all IDLE modules. (GH-7689)
https://github.com/python/cpython/commit/508568764593dca3844a51c10f1493413a51d66f
msg319761 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-16 16:49
New changeset 833b3d2dcc7043be20ac19f7821552fcb21f4365 by Terry Jan Reedy in branch '3.6':
[3.6] bpo-33855: Minimally test all IDLE modules. (GH-7689) (GH-7734)
https://github.com/python/cpython/commit/833b3d2dcc7043be20ac19f7821552fcb21f4365
msg319871 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-18 08:48
New changeset ea3dc8029ab6a0f1ee6a8a72f1612dea74892e08 by Terry Jan Reedy in branch 'master':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
https://github.com/python/cpython/commit/ea3dc8029ab6a0f1ee6a8a72f1612dea74892e08
msg319873 - (view) Author: miss-islington (miss-islington) Date: 2018-06-18 09:10
New changeset 740f1cb20a8ae6e7f6daa14f2e240664643ce757 by Miss Islington (bot) in branch '3.7':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
https://github.com/python/cpython/commit/740f1cb20a8ae6e7f6daa14f2e240664643ce757
msg319874 - (view) Author: miss-islington (miss-islington) Date: 2018-06-18 09:11
New changeset 684bc3d67797f2b5ca9368fe7ecc1c3093d7b694 by Miss Islington (bot) in branch '3.6':
bpo-33855: More edits and new minimal tests for IDLE (GH-7761)
https://github.com/python/cpython/commit/684bc3d67797f2b5ca9368fe7ecc1c3093d7b694
msg319925 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-19 03:53
Spinoffs:
 change rstrip.RstripExtension to Rstrip
 change stackviewer.StackBrowser to accept exception
msg319997 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-19 21:01
Change windows.py to window.py, in line with change of menu.  Should be safer with everything imported.
msg320006 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-19 23:12
New changeset 4d92158f4c3917fc4fbfebff15224e74782abf79 by Terry Jan Reedy in branch 'master':
bpo-33855: Still more edits and minimal tests for IDLE  (GH-7784)
https://github.com/python/cpython/commit/4d92158f4c3917fc4fbfebff15224e74782abf79
msg320008 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 00:11
New changeset cbaee6fe02d22f357c2edf4e463c240d5df22f14 by Miss Islington (bot) in branch '3.7':
bpo-33855: Still more edits and minimal tests for IDLE  (GH-7784)
https://github.com/python/cpython/commit/cbaee6fe02d22f357c2edf4e463c240d5df22f14
msg320009 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 00:11
New changeset 90209a172c5b629f512cf292a22950285a2c3d81 by Miss Islington (bot) in branch '3.6':
bpo-33855: Still more edits and minimal tests for IDLE  (GH-7784)
https://github.com/python/cpython/commit/90209a172c5b629f512cf292a22950285a2c3d81
msg320011 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 02:32
Still open for a patch explaining idle_test.template in README.

I opened #33904 for rstrip, #33905 for stackbrowser, #33906 for windows, and #33907 for calltips/CallTip renaming.
msg320102 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 18:41
#33917 is about fixing and documenting template.py.
History
Date User Action Args
2022-04-11 14:59:01adminsetgithub: 78036
2018-06-21 14:44:40terry.reedysetversions: + Python 3.8, - Python 3.5
2018-06-21 14:44:10terry.reedysetversions: - Python 2.7
2018-06-21 14:39:00terry.reedysetstatus: open -> closed
stage: test needed -> resolved
resolution: fixed
versions: + Python 2.7, Python 3.5, - Python 3.8
2018-06-20 18:41:47terry.reedysetdependencies: + Fix and document idlelib/idle_test/template.py
messages: + msg320102
2018-06-20 02:32:35terry.reedysetmessages: + msg320011
stage: patch review -> test needed
2018-06-20 00:11:51miss-islingtonsetmessages: + msg320009
2018-06-20 00:11:26miss-islingtonsetmessages: + msg320008
2018-06-19 23:15:03miss-islingtonsetpull_requests: + pull_request7412
2018-06-19 23:14:12miss-islingtonsetstage: test needed -> patch review
pull_requests: + pull_request7411
2018-06-19 23:12:57terry.reedysetmessages: + msg320006
2018-06-19 21:01:32terry.reedysetmessages: + msg319997
stage: patch review -> test needed
2018-06-19 04:00:15terry.reedysetstage: test needed -> patch review
pull_requests: + pull_request7389
2018-06-19 03:53:25terry.reedysetmessages: + msg319925
stage: patch review -> test needed
2018-06-18 09:11:15miss-islingtonsetmessages: + msg319874
2018-06-18 09:10:47miss-islingtonsetmessages: + msg319873
2018-06-18 08:50:12miss-islingtonsetpull_requests: + pull_request7382
2018-06-18 08:49:18miss-islingtonsetpull_requests: + pull_request7381
2018-06-18 08:48:11terry.reedysetmessages: + msg319871
2018-06-17 06:55:36terry.reedysetpull_requests: + pull_request7369
2018-06-16 16:49:12terry.reedysetmessages: + msg319761
2018-06-15 22:51:47terry.reedysetpull_requests: + pull_request7345
2018-06-15 22:38:37miss-islingtonsetnosy: + miss-islington
messages: + msg319687
2018-06-15 22:22:07miss-islingtonsetstage: test needed -> patch review
pull_requests: + pull_request7344
2018-06-15 22:20:58terry.reedysetmessages: + msg319683
2018-06-15 20:38:29terry.reedysetmessages: + msg319668
stage: patch review -> test needed
2018-06-14 10:17:35taleinatsetmessages: + msg319506
2018-06-14 07:20:06terry.reedysetkeywords: + patch
stage: test needed -> patch review
pull_requests: + pull_request7303
2018-06-14 07:13:13terry.reedycreate