This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE: Rename calltips and CallTips as calltip and Calltip.
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, terry.reedy
Priority: normal Keywords: patch

Created on 2018-06-19 23:04 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7807 merged terry.reedy, 2018-06-20 02:27
PR 7808 merged miss-islington, 2018-06-20 03:01
PR 7809 merged terry.reedy, 2018-06-20 03:43
PR 7810 merged terry.reedy, 2018-06-20 04:30
PR 7812 merged miss-islington, 2018-06-20 06:19
PR 7813 merged miss-islington, 2018-06-20 06:19
Messages (9)
msg320004 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-19 23:04
Rename module 'calltips' as 'calltip'
1. 'calltips' and 'windows' are the only two plural module names.
2. 'calltip' fits better with 'calltip_w' (which may, however, be merged 
in 'calltip'.
Module rename can be checked as with 'window', #33906.

and class CallTips as Calltip.
3. This may be the only plural class name.
4. ToolTip is singular and will be changed to Tooltip in #33839.  See the 6/17 and 6/19 messages.
Needed changes in other modules will not necessarily be caught by existing tests.  Use grep for 'CallTips'.

I will not change tooltip.py (currently not used or tested) as change here would conflict with current PR for #33839.
msg320012 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 03:00
New changeset 06e2029dfa500a42e3565ed7ba8573412f153d1c by Terry Jan Reedy in branch 'master':
bpo-33907: Rename an IDLE module and class. (GH-7807)
https://github.com/python/cpython/commit/06e2029dfa500a42e3565ed7ba8573412f153d1c
msg320013 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 03:27
New changeset b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2 by Miss Islington (bot) in branch '3.7':
bpo-33907: Rename an IDLE module and class. (GH-7807)
https://github.com/python/cpython/commit/b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2
msg320014 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 03:50
I also changed calltips.CallTips to calltip.Calltip, which is the same class name as for calltip_w.Calltip (formerly CallTip).  This is confusing now and would block merging the files.  Change the latter to calltip_w.CalltipW (for Window).
msg320015 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 03:55
The calltip window class name is only used in 4 places, so I decided to expand to CalltipWindow.
msg320017 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 04:22
New changeset e97a685185b82ba6de6de576fc2a4cf3cd6192af by Terry Jan Reedy in branch '3.6':
 [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807)  (GH-7809)
https://github.com/python/cpython/commit/e97a685185b82ba6de6de576fc2a4cf3cd6192af
msg320021 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 06:18
New changeset 9af1836664d241fec6e62955ffaa559b3a2eaf1b by Terry Jan Reedy in branch 'master':
bpo-33907: Rename an IDLE module and classes. (GH-7810)
https://github.com/python/cpython/commit/9af1836664d241fec6e62955ffaa559b3a2eaf1b
msg320025 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 06:40
New changeset ce52f5ee0925925f5662f6b34cc637cfe6c0a46e by Miss Islington (bot) in branch '3.7':
bpo-33907: Rename an IDLE module and classes. (GH-7810)
https://github.com/python/cpython/commit/ce52f5ee0925925f5662f6b34cc637cfe6c0a46e
msg320026 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 06:40
New changeset 17d4c53fa3516f78df3c4f343bc6d2007af157cf by Miss Islington (bot) in branch '3.6':
bpo-33907: Rename an IDLE module and classes. (GH-7810)
https://github.com/python/cpython/commit/17d4c53fa3516f78df3c4f343bc6d2007af157cf
History
Date User Action Args
2022-04-11 14:59:01adminsetgithub: 78088
2018-06-20 06:41:08terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-20 06:40:32miss-islingtonsetmessages: + msg320026
2018-06-20 06:40:17miss-islingtonsetnosy: + miss-islington
messages: + msg320025
2018-06-20 06:19:59miss-islingtonsetpull_requests: + pull_request7420
2018-06-20 06:19:14miss-islingtonsetpull_requests: + pull_request7419
2018-06-20 06:18:51terry.reedysetmessages: + msg320021
2018-06-20 04:30:07terry.reedysetstage: needs patch -> patch review
pull_requests: + pull_request7416
2018-06-20 04:22:51terry.reedysetmessages: + msg320017
2018-06-20 03:55:06terry.reedysetmessages: + msg320015
2018-06-20 03:50:04terry.reedysetnosy: - miss-islington

messages: + msg320014
stage: patch review -> needs patch
2018-06-20 03:43:09terry.reedysetpull_requests: + pull_request7415
2018-06-20 03:27:40miss-islingtonsetnosy: + miss-islington
messages: + msg320013
2018-06-20 03:01:57miss-islingtonsetpull_requests: + pull_request7414
2018-06-20 03:00:39terry.reedysetmessages: + msg320012
2018-06-20 02:27:26terry.reedysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7413
2018-06-19 23:07:34terry.reedylinkissue33839 dependencies
2018-06-19 23:04:35terry.reedycreate