This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: IDLE: rename as
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, terry.reedy
Priority: normal Keywords: easy, patch

Created on 2018-06-19 22:52 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7833 merged terry.reedy, 2018-06-21 00:57
PR 7834 merged miss-islington, 2018-06-21 01:27
PR 7835 merged miss-islington, 2018-06-21 01:28
Messages (6)
msg320003 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-19 22:52
Change module 'windows' to 'window'::
1. 'calltips' and 'windows' are the only two plural module names.
2. The top menu entry was changed from 'Windows' to 'Window' some time ago.
3. 'windows' is also a OS.

With all modules at least imported in a test, all imports in modules should be checked, so running test_idle after changing the file name should reveal all imports that need to be changed.

What could have been the 'Window' class is called 'ListedTopLevel'.
msg320027 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 06:45
Also rename idle_test.test_windows as test_window with git mv.  Imports:

F:\dev\3x\lib\idlelib\ 28: from idlelib import windows
F:\dev\3x\lib\idlelib\idle_test\ 3: from idlelib import windows
F:\dev\3x\lib\idlelib\ 131:     from idlelib import windows
msg320122 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 22:26
Marking 2.7 for a search test.
msg320129 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-21 01:26
New changeset a361e89d5ae3daefe9e8b8a7e889cd2ad8c45b77 by Terry Jan Reedy in branch 'master':
bpo-33906: Rename as window (#7833)
msg320131 - (view) Author: miss-islington (miss-islington) Date: 2018-06-21 01:45
New changeset f9243a22da6a609143e27abf3ca37a4f63d5aae9 by Miss Islington (bot) in branch '3.7':
bpo-33906: Rename as window (GH-7833)
msg320132 - (view) Author: miss-islington (miss-islington) Date: 2018-06-21 01:52
New changeset 2839da4e51da5d66fa3d6e57eba4ba04f0641dab by Miss Islington (bot) in branch '3.6':
bpo-33906: Rename as window (GH-7833)
Date User Action Args
2022-04-11 14:59:01adminsetgithub: 78087
2018-06-21 02:05:06terry.reedysetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-21 01:52:23miss-islingtonsetmessages: + msg320132
2018-06-21 01:45:38miss-islingtonsetnosy: + miss-islington
messages: + msg320131
2018-06-21 01:28:12miss-islingtonsetpull_requests: + pull_request7444
2018-06-21 01:27:15miss-islingtonsetpull_requests: + pull_request7443
2018-06-21 01:26:02terry.reedysetmessages: + msg320129
2018-06-21 00:57:08terry.reedysetpull_requests: + pull_request7442
2018-06-20 22:28:21terry.reedysetversions: - Python 2.7
2018-06-20 22:26:36terry.reedysetmessages: + msg320122
versions: + Python 2.7
2018-06-20 07:12:54terry.reedysetpull_requests: - pull_request7421
2018-06-20 06:48:51thatiparthysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7421
2018-06-20 06:45:47terry.reedysetkeywords: + easy

messages: + msg320027
2018-06-19 22:53:51terry.reedysettitle: IDLE: change to -> IDLE: rename as
2018-06-19 22:52:37terry.reedycreate