This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: IDLE: Test stackbrowser.Stackbrowser
Type: enhancement Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: miss-islington, terry.reedy
Priority: normal Keywords: patch

Created on 2018-06-19 22:26 by terry.reedy, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7852 merged terry.reedy, 2018-06-22 00:53
PR 7853 merged miss-islington, 2018-06-22 02:20
PR 7854 merged miss-islington, 2018-06-22 02:21
Messages (4)
msg320203 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-22 02:20
New changeset bcd3a1a18d841338f57c39f6a7de8cf14d0c3e03 by Terry Jan Reedy in branch 'master':
bpo-33905: Add test for idlelib.stackview.StackBrowser. (GH-7852)
https://github.com/python/cpython/commit/bcd3a1a18d841338f57c39f6a7de8cf14d0c3e03
msg320205 - (view) Author: miss-islington (miss-islington) Date: 2018-06-22 02:48
New changeset d554414d981a8bfe38cc5df5751bc3efcb0c36c3 by Miss Islington (bot) in branch '3.7':
bpo-33905: Add test for idlelib.stackview.StackBrowser. (GH-7852)
https://github.com/python/cpython/commit/d554414d981a8bfe38cc5df5751bc3efcb0c36c3
msg320206 - (view) Author: miss-islington (miss-islington) Date: 2018-06-22 02:49
New changeset a0622f1071164bc67a307cfec1173c295901c4b9 by Miss Islington (bot) in branch '3.6':
bpo-33905: Add test for idlelib.stackview.StackBrowser. (GH-7852)
https://github.com/python/cpython/commit/a0622f1071164bc67a307cfec1173c295901c4b9
msg320208 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-22 02:52
(My initial messages contained a mistaken idea based on a mis-remembering the details sys.last values and exceptions.)

If an exception is not caught and a traceback is printed, sys.last_type, sys.last_value, and sys.last_traceback are set.  When an exception is caught, the last_ x values are not touched, but the same are available by calling sys.exc_info.  Stackview accessed all 3 sys.last_x values, but they are not normally set when testing because exception are caught.  The test sets them from a sys.exc_info after catching an exception.
History
Date User Action Args
2022-04-11 14:59:01adminsetgithub: 78086
2018-06-22 02:52:14terry.reedysetstatus: open -> closed
title: IDLE: stackbrowser.Stackbrowser should accept exception. -> IDLE: Test stackbrowser.Stackbrowser
type: behavior -> enhancement
messages: + msg320208

resolution: fixed
stage: patch review -> resolved
2018-06-22 02:49:08miss-islingtonsetmessages: + msg320206
2018-06-22 02:48:48miss-islingtonsetnosy: + miss-islington
messages: + msg320205
2018-06-22 02:21:10miss-islingtonsetpull_requests: + pull_request7465
2018-06-22 02:20:11miss-islingtonsetpull_requests: + pull_request7464
2018-06-22 02:20:03terry.reedysetmessages: + msg320203
2018-06-22 00:53:46terry.reedysetkeywords: + patch
stage: test needed -> patch review
pull_requests: + pull_request7463
2018-06-21 23:26:11terry.reedyset -> (no value)
messages: - msg320028
2018-06-21 23:26:02terry.reedysetmessages: - msg320002
2018-06-20 06:47:00terry.reedysetmessages: + msg320028
2018-06-19 22:26:07terry.reedycreate