This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Fix and document idlelib/idle_test/
Type: behavior Stage: resolved
Components: IDLE Versions: Python 3.8, Python 3.7, Python 3.6
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: cheryl.sabella, doko, miss-islington, ned.deily, taleinat, terry.reedy
Priority: Keywords: 3.6regression, 3.7regression

Created on 2018-06-20 16:54 by doko, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 7830 merged terry.reedy, 2018-06-20 20:40
PR 7831 merged miss-islington, 2018-06-20 21:09
PR 7832 merged miss-islington, 2018-06-20 21:10
Messages (7)
msg320099 - (view) Author: Matthias Klose (doko) * (Python committer) Date: 2018-06-20 16:54
Seen with the 3.6 branch and the 3.7 branch at least. This file is installed by default, so should be valid syntax?  If it's supposed to be that way, maybe call the template like

  Unpacking libpython3.6-testsuite (3.6.6~rc1-3) ...
  Setting up libpython3.6-testsuite (3.6.6~rc1-3) ...
    File "/usr/lib/python3.6/idlelib/idle_test/", line 3
      from idlelib import
  SyntaxError: invalid syntax
msg320103 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 18:44
I wrote it intentionally the way it is, for #33855, as it made it maximally easily to use to complete the test suite.  Since it caused a problem, I added a valid dummy name to be replaced, and fixed the other syntax error.  The file now compiles, runs, and tests OK.  New IDLE modules needing a new test file should be rare.

I will submit the PR after I edit the readme to document the usage of the template.
msg320112 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 20:57
Tal and Cheryl: I revised the template for IDLE tests, pulled it out of README.txt into, and explained it in the readme.  It has new code for cleaning up after instantiating EditorWindow in tests.  Please follow for any new test file, including test_tooltip and test_squeezer.  (They should both be pretty close already.)
msg320114 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2018-06-20 21:08
New changeset 87a927325e3856621790a39d8718ff24a19510aa by Terry Jan Reedy in branch 'master':
bpo-33917: Fix and document idlelib/idle_test/ (GH-7830)
msg320117 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 21:27
New changeset a717c5646b36a42e4eb0ec4ae2a22520ff47d346 by Miss Islington (bot) in branch '3.7':
bpo-33917: Fix and document idlelib/idle_test/ (GH-7830)
msg320119 - (view) Author: miss-islington (miss-islington) Date: 2018-06-20 21:33
New changeset 7c853d0620e1ea838f46642dbaa8ef142d80aa01 by Miss Islington (bot) in branch '3.6':
bpo-33917: Fix and document idlelib/idle_test/ (GH-7830)
msg320527 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2018-06-27 00:12
FTR, the problem change was merged/backported after 3.7.0rc1 and 3.6.6rc1 so doko must have been working from a development branch and not a release tag.  The original and its fix will first be officially released in 3.7.1 and 3.6.7 so there's really no need for a correction NEWS entry; it doesn't hurt either.
Date User Action Args
2022-04-11 14:59:02adminsetgithub: 78098
2018-06-27 00:12:17ned.deilysetpriority: release blocker ->

messages: + msg320527
2018-06-20 21:59:44terry.reedysetkeywords: - patch
status: open -> closed
resolution: fixed
stage: patch review -> resolved
2018-06-20 21:33:21miss-islingtonsetmessages: + msg320119
2018-06-20 21:27:46miss-islingtonsetnosy: + miss-islington
messages: + msg320117
2018-06-20 21:10:44miss-islingtonsetpull_requests: + pull_request7441
2018-06-20 21:09:45miss-islingtonsetkeywords: + patch
stage: commit review -> patch review
pull_requests: + pull_request7440
2018-06-20 21:08:34terry.reedysetmessages: + msg320114
2018-06-20 20:57:53terry.reedysetstage: needs patch -> commit review
2018-06-20 20:57:40terry.reedysetnosy: + taleinat, cheryl.sabella
messages: + msg320112

keywords: - patch
stage: patch review -> needs patch
2018-06-20 20:40:06terry.reedysetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request7439
2018-06-20 18:45:02terry.reedysetnosy: + ned.deily

versions: + Python 3.6, Python 3.7, Python 3.8
2018-06-20 18:44:47terry.reedysettype: behavior
title: idlelib/idle_test/ has invalid syntax -> Fix and document idlelib/idle_test/
messages: + msg320103
stage: needs patch
2018-06-20 18:41:47terry.reedylinkissue33855 dependencies
2018-06-20 16:54:43dokocreate