classification
Title: Fix false positives in circular import detection with from-imports
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.10, Python 3.9
process
Status: closed Resolution:
Dependencies: Superseder:
Assigned To: pitrou Nosy List: brett.cannon, cebtenzzre, eric.snow, gregory.p.smith, miss-islington, nanjekyejoannah, ncoghlan, pitrou, serhiy.storchaka
Priority: deferred blocker Keywords: patch

Created on 2021-03-16 16:07 by pitrou, last changed 2021-03-20 21:52 by pitrou. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 24895 merged pitrou, 2021-03-16 16:15
PR 24948 merged pitrou, 2021-03-20 19:17
PR 24950 merged pitrou, 2021-03-20 20:23
PR 24951 merged pitrou, 2021-03-20 21:01
Messages (6)
msg388854 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2021-03-16 16:11
This seems to be caused by a logic error in the patch for issue35943.

It has been causing multiple issues for multi-threaded and multi-process systems written in Python:
* issue41567
* issue43515
* https://github.com/dask/distributed/issues/4168
msg389172 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2021-03-20 19:07
New changeset 2fd16ef406bba239b1334057fb499496a84b3aa2 by Antoine Pitrou in branch 'master':
bpo-43517: Fix false positive in detection of circular imports (#24895)
https://github.com/python/cpython/commit/2fd16ef406bba239b1334057fb499496a84b3aa2
msg389174 - (view) Author: miss-islington (miss-islington) Date: 2021-03-20 19:40
New changeset ac17ed60f2033253248be494a8e1980fe7e3531d by Antoine Pitrou in branch '3.9':
[3.9] bpo-43517: Fix false positive in detection of circular imports (GH-24895) (GH-24948)
https://github.com/python/cpython/commit/ac17ed60f2033253248be494a8e1980fe7e3531d
msg389179 - (view) Author: miss-islington (miss-islington) Date: 2021-03-20 20:46
New changeset 66c8adfa27aeea004657ef29b6db4e4c360ad611 by Antoine Pitrou in branch 'master':
bpo-43517 (followup): Install additional test directory (GH-24950)
https://github.com/python/cpython/commit/66c8adfa27aeea004657ef29b6db4e4c360ad611
msg389183 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2021-03-20 21:50
Thanks Antoine!
msg389185 - (view) Author: miss-islington (miss-islington) Date: 2021-03-20 21:52
New changeset 107cf078910db7c1cafdd486270ba8083d72aed7 by Antoine Pitrou in branch '3.9':
[3.9] bpo-43517 (followup): Install additional test directory (GH-24950) (GH-24951)
https://github.com/python/cpython/commit/107cf078910db7c1cafdd486270ba8083d72aed7
History
Date User Action Args
2021-03-20 21:52:36pitrousetstatus: open -> closed
stage: patch review -> resolved
2021-03-20 21:52:07miss-islingtonsetmessages: + msg389185
2021-03-20 21:50:16gregory.p.smithsetnosy: + gregory.p.smith
messages: + msg389183
2021-03-20 21:01:25pitrousetpull_requests: + pull_request23709
2021-03-20 20:46:07miss-islingtonsetmessages: + msg389179
2021-03-20 20:23:21pitrousetpull_requests: + pull_request23708
2021-03-20 19:40:28miss-islingtonsetnosy: + miss-islington
messages: + msg389174
2021-03-20 19:17:01pitrousetpull_requests: + pull_request23706
2021-03-20 19:07:52pitrousetmessages: + msg389172
2021-03-16 22:20:05cebtenzzresetnosy: + cebtenzzre
2021-03-16 16:17:45serhiy.storchakasetnosy: + brett.cannon, ncoghlan, eric.snow, serhiy.storchaka, nanjekyejoannah
2021-03-16 16:17:16pitroulinkissue43515 superseder
2021-03-16 16:16:54pitroulinkissue41567 superseder
2021-03-16 16:15:12pitrousetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request23660
2021-03-16 16:11:03pitrousetmessages: + msg388854
2021-03-16 16:07:50pitroucreate