classification
Title: indentation fix in ceval.c in python 2.7
Type: Stage: resolved
Components: Interpreter Core Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Laurent Coustet, benjamin.peterson, brett.cannon, pitrou, python-dev, r.david.murray
Priority: normal Keywords: patch

Created on 2015-08-19 10:01 by Laurent Coustet, last changed 2015-08-20 03:39 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
cpython2.7_indentfix_ceval.diff Laurent Coustet, 2015-08-19 10:01 review
Messages (6)
msg248827 - (view) Author: Laurent Coustet (Laurent Coustet) * Date: 2015-08-19 10:01
https://hg.python.org/cpython/rev/17d3bbde60d2

introduced a patch using tabs for indentation in ceval.c.

Attached patch just make the code more consistent by using spaces instead of tabs for indentation.


Related to: http://bugs.python.org/issue4753
msg248846 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2015-08-19 16:04
Thanks for the patch, Laurent.

Can any other core devs remembered if we explicitly untabbed the C source in 2.7? I know we did in Python 3, but I can't remember if we did it in Python 2 to make patches easier.
msg248851 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2015-08-19 16:42
I couldn't remember either.  Antoine should know, he did the work/commit.
msg248852 - (view) Author: Laurent Coustet (Laurent Coustet) * Date: 2015-08-19 16:43
by the way, the rest of the code did not contain any tab in ceval.c. They were added by 17d3bbde60d2
msg248853 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2015-08-19 16:53
The Python 3 code doesn't have tabs. I'm assuming Benjamin took the original patch instead of trying to backport the Python 3 commit.
msg248873 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-08-20 03:38
New changeset ea2f6fd04307 by Benjamin Peterson in branch '2.7':
remove tabs from ceval.c (closes #24895)
https://hg.python.org/cpython/rev/ea2f6fd04307
History
Date User Action Args
2015-08-20 03:39:00python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg248873

resolution: fixed
stage: patch review -> resolved
2015-08-19 17:09:17vstinnersettitle: indentation fix in ceval.c -> indentation fix in ceval.c in python 2.7
2015-08-19 16:53:10pitrousetnosy: + benjamin.peterson
messages: + msg248853
2015-08-19 16:43:44Laurent Coustetsetmessages: + msg248852
2015-08-19 16:42:38r.david.murraysetnosy: + r.david.murray, pitrou
messages: + msg248851
2015-08-19 16:04:57brett.cannonsetnosy: + brett.cannon

messages: + msg248846
stage: patch review
2015-08-19 10:01:43Laurent Coustetcreate