msg376175 - (view) |
Author: Kyle Stanley (aeros) *  |
Date: 2020-09-01 01:24 |
In an unrelated PR to add a new argument to the base Executor class for concurrent.futures, there was a test_asyncio failure in test_sendfile for the ProactorEventLoop tests:
======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 452, in test_sendfile_close_peer_in_the_middle_of_receiving
self.run_loop(
AssertionError: ConnectionError not raised
----------------------------------------------------------------------
https://github.com/python/cpython/pull/22023/checks?check_run_id=1049760805#step:5:2373
|
msg376176 - (view) |
Author: Kyle Stanley (aeros) *  |
Date: 2020-09-01 01:36 |
In case the link to the logs are lost from closing and reopening the PR, it was a Windows CI test (GitHub actions) ran with the following configuration:
D:\a\cpython\cpython>"D:\a\cpython\cpython\PCbuild\amd64\python.exe" -u -Wd -E -bb -m test -uall -u-cpu -rwW --slowest --timeout 1200 -j0
== CPython 3.10.0a0 (remotes/pull/22023/merge:992cc27, Aug 31 2020, 06:11:21) [MSC v.1927 64 bit (AMD64)]
== Windows-10-10.0.17763-SP0 little-endian
== cwd: D:\a\cpython\cpython\build\test_python_6372�
== CPU count: 2
== encodings: locale=cp1252, FS=utf-8
Using random seed 491155
0:00:00 Run tests in parallel using 4 child processes (timeout: 20 min, worker timeout: 25 min)
|
msg391134 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2021-04-15 12:53 |
I marked bpo-42124 and bpo-43539 as a duplicate of this issue.
|
msg392061 - (view) |
Author: Alyssa Coghlan (ncoghlan) *  |
Date: 2021-04-27 12:27 |
Another instance at https://github.com/python/cpython/pull/25585/checks?check_run_id=2447701034
I unlinked the previously linked PR, as that looked to be for bpo-43539 rather than this issue.
|
msg396238 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2021-06-21 12:23 |
This bug still occurs time to time on GitHub Actions.
https://github.com/python/cpython/pull/26826/checks?check_run_id=2874631119
======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):
AssertionError: ConnectionError not raised
|
msg396503 - (view) |
Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2021-06-24 16:56 |
Two new failures today:
https://github.com/python/cpython/runs/2905621215:
2021-06-24T14:18:23.3772681Z ======================================================================
2021-06-24T14:18:23.3773622Z FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-06-24T14:18:23.3774665Z ----------------------------------------------------------------------
2021-06-24T14:18:23.3775258Z Traceback (most recent call last):
2021-06-24T14:18:23.3776123Z File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
2021-06-24T14:18:23.3777065Z with self.assertRaises(ConnectionError):
2021-06-24T14:18:23.3777775Z AssertionError: ConnectionError not raised
2021-06-24T14:18:23.3778226Z
2021-06-24T14:18:23.3778744Z ----------------------------------------------------------------------
2021-06-24T14:18:23.3779161Z
2021-06-24T14:18:23.3779555Z Ran 2022 tests in 54.341s
2021-06-24T14:18:23.3779870Z
2021-06-24T14:18:23.3780352Z FAILED (failures=1, skipped=63)
2021-06-24T14:18:23.3780890Z test test_asyncio failed
https://github.com/python/cpython/runs/2906141524:
2021-06-24T15:23:11.7177493Z ======================================================================
2021-06-24T15:23:11.7178338Z FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-06-24T15:23:11.7179234Z ----------------------------------------------------------------------
2021-06-24T15:23:11.7179754Z Traceback (most recent call last):
2021-06-24T15:23:11.7180469Z File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
2021-06-24T15:23:11.7181284Z with self.assertRaises(ConnectionError):
2021-06-24T15:23:11.7182125Z AssertionError: ConnectionError not raised
2021-06-24T15:23:11.7182560Z
2021-06-24T15:23:11.7183334Z ----------------------------------------------------------------------
2021-06-24T15:23:11.7183839Z
|
msg399770 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2021-08-17 17:01 |
Recent failure on GHA Windows x64:
https://github.com/python/cpython/runs/3342514542
2021-08-16T17:19:58.4338049Z ======================================================================
2021-08-16T17:19:58.4339129Z FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-08-16T17:19:58.4340315Z ----------------------------------------------------------------------
2021-08-16T17:19:58.4340937Z Traceback (most recent call last):
2021-08-16T17:19:58.4341846Z File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
2021-08-16T17:19:58.4342849Z with self.assertRaises(ConnectionError):
2021-08-16T17:19:58.4343398Z ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2021-08-16T17:19:58.4343982Z AssertionError: ConnectionError not raised
|
msg402294 - (view) |
Author: Nikita Sobolev (sobolevn) *  |
Date: 2021-09-21 08:53 |
Happened to me today: https://dev.azure.com/Python/cpython/_build/results?buildId=88208&view=logs&j=c83831cd-3752-5cc7-2f01-8276919eb334&t=5a421c4a-0933-53d5-26b9-04b36ad165eb
```
test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests) ... FAIL
test test_asyncio failed
test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok
======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\1\s\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: ConnectionError not raised
----------------------------------------------------------------------
Ran 2 tests in 0.087s
FAILED (failures=1)
0:08:56 load avg: 3.51 Re-running test_concurrent_futures in verbose mode (matching: test_cancel_futures_wait_false)
test_cancel_futures_wait_false (test.test_concurrent_futures.ThreadPoolShutdownTest) ... ok
----------------------------------------------------------------------
Ran 1 test in 0.303s
OK
1 test failed again:
test_asyncio
```
|
msg404820 - (view) |
Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2021-10-22 20:24 |
New failure today: https://github.com/python/cpython/runs/3979900415?check_suite_focus=true
test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok
======================================================================
FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
with self.assertRaises(ConnectionError):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: ConnectionError not raised
|
msg408612 - (view) |
Author: Ken Jin (kj) *  |
Date: 2021-12-15 15:20 |
Happened to a PR I was reviewing today:
https://github.com/python/cpython/runs/4535247255?check_suite_focus=true
|
msg411293 - (view) |
Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2022-01-22 22:07 |
Previously, this failure was more sporadic; now it happens almost every single run on the Azure CI. Has there been updates on the Azure CI lately?
|
msg411299 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-22 22:52 |
New changeset 1ded8ed8e817b8f9dae1a0ef92d97983afbc844e by Nikita Sobolev in branch 'main':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801)
https://github.com/python/cpython/commit/1ded8ed8e817b8f9dae1a0ef92d97983afbc844e
|
msg411313 - (view) |
Author: miss-islington (miss-islington) |
Date: 2022-01-23 00:20 |
New changeset ba932d90244252f6d4073263f25989507a183f79 by Miss Islington (bot) in branch '3.9':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801)
https://github.com/python/cpython/commit/ba932d90244252f6d4073263f25989507a183f79
|
msg411322 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-23 00:58 |
New changeset 486b4d3d8e1a5699a2854e310c58fe12b220b7a9 by Miss Islington (bot) in branch '3.10':
bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801) (GH-30812)
https://github.com/python/cpython/commit/486b4d3d8e1a5699a2854e310c58fe12b220b7a9
|
msg411386 - (view) |
Author: Guido van Rossum (gvanrossum) *  |
Date: 2022-01-23 17:30 |
I'm wondering if the test is faulty. It seems to call EventLoop.sendfile() with a file that is 8K + 1 byte long,
and the protocol is instructed to close after 1K bytes have been written, but it seems to try to send as much of the file as it can.
Could it be that on Win22 the primitive used (TransmitFile) has an internal minimum buffer size that exceeds this file size, so the first call sends the whole file and there's no error?
@Andrew Svetlov, do you know enough of the internals of this code to validate my theory?
|
msg411508 - (view) |
Author: Andrew Svetlov (asvetlov) *  |
Date: 2022-01-24 19:16 |
Guido, I can not confirm your suggestion but it seems correct to me.
|
msg411638 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 17:39 |
Test fixed on Windows 2022 by:
commit 1c705fda8f9902906edd26d46acb0433b0b098e1
Author: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Date: Tue Jan 25 02:34:47 2022 +0530
fixed flaky test (GH-30845)
|
msg411639 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 17:40 |
New changeset 75d88b91e6b1320ae0511eaf72e860bea913a3eb by Miss Islington (bot) in branch '3.10':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (#30860)
https://github.com/python/cpython/commit/75d88b91e6b1320ae0511eaf72e860bea913a3eb
|
msg411640 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 17:40 |
New changeset f9ff0bf515e0fa162889aca508e755cc65d85079 by Miss Islington (bot) in branch '3.9':
bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (#30861)
https://github.com/python/cpython/commit/f9ff0bf515e0fa162889aca508e755cc65d85079
|
msg411641 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 17:41 |
Thanks Kumar for the fix!
|
msg411643 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 17:45 |
This failing test was one of my most hated test because it failed randomly for almost 2 years. I'm happy that it has been fixed :-)
Regularly, I'm asking for help to fix test_asyncio:
* October 2020: https://mail.python.org/archives/list/python-dev@python.org/message/Y7I5ADXAQEGK6DOFAPVDTKMBT6NUFNQ4/
* October 2019: https://mail.python.org/archives/list/python-dev@python.org/message/R7X6NKGEOKWD3PBWIL2LPZWZ6MMRANN5/
Last years I gave up, since almost no one replied to my requests.
|
msg411646 - (view) |
Author: Andrew Svetlov (asvetlov) *  |
Date: 2022-01-25 17:56 |
I'm sorry, Victor.
|
msg411651 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2022-01-25 18:03 |
> I'm sorry, Victor.
As a maintainer of the Python CIs, The Night's Watch (*), it's my fault that I didn't skip these tests earlier. Honestly, it's ok to skip a bunch of tests or even remove them if there is no active maintainer.
It's also ok that there is no active maintainer if existing tests continue to pass. asyncio is far from being an exception. Just look at test_nntplib: not maintained for 9 years, https://bugs.python.org/issue40735
This test failure got more attention since it started to fail even more frequently (always?) on Windows 2022.
(*) https://pythondev.readthedocs.io/ci.html#the-night-s-watch-is-fixing-the-cis-in-the-darkness-for-you
|
|
Date |
User |
Action |
Args |
2022-04-11 14:59:35 | admin | set | github: 85848 |
2022-01-25 18:03:17 | vstinner | set | messages:
+ msg411651 |
2022-01-25 17:56:21 | asvetlov | set | messages:
+ msg411646 |
2022-01-25 17:45:34 | vstinner | set | messages:
+ msg411643 title: [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure -> [Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure |
2022-01-25 17:41:06 | vstinner | set | status: open -> closed resolution: fixed messages:
+ msg411641
stage: patch review -> resolved |
2022-01-25 17:40:38 | vstinner | set | messages:
+ msg411640 |
2022-01-25 17:40:34 | vstinner | set | messages:
+ msg411639 |
2022-01-25 17:40:23 | miss-islington | set | pull_requests:
+ pull_request29072 |
2022-01-25 17:40:02 | miss-islington | set | pull_requests:
+ pull_request29071 |
2022-01-25 17:39:34 | vstinner | set | messages:
+ msg411638 |
2022-01-24 19:16:22 | asvetlov | set | messages:
+ msg411508 |
2022-01-24 08:28:07 | kumaraditya | set | nosy:
+ kumaraditya pull_requests:
+ pull_request29027
|
2022-01-23 17:30:29 | gvanrossum | set | nosy:
+ gvanrossum messages:
+ msg411386
|
2022-01-23 02:54:16 | vstinner | set | stage: needs patch -> patch review pull_requests:
+ pull_request29006 |
2022-01-23 00:58:24 | vstinner | set | messages:
+ msg411322 |
2022-01-23 00:39:35 | jaraco | set | stage: patch review -> needs patch |
2022-01-23 00:20:52 | miss-islington | set | messages:
+ msg411313 |
2022-01-22 22:53:09 | miss-islington | set | pull_requests:
+ pull_request29000 |
2022-01-22 22:53:03 | miss-islington | set | nosy:
+ miss-islington pull_requests:
+ pull_request28999
|
2022-01-22 22:52:34 | vstinner | set | nosy:
+ vstinner messages:
+ msg411299
|
2022-01-22 22:07:56 | erlendaasland | set | messages:
+ msg411293 |
2022-01-22 21:03:14 | arhadthedev | set | nosy:
+ arhadthedev
|
2022-01-22 19:28:45 | sobolevn | set | keywords:
+ patch pull_requests:
+ pull_request28986 |
2021-12-15 17:18:58 | vstinner | set | nosy:
- vstinner
|
2021-12-15 15:20:38 | kj | set | versions:
+ Python 3.11 nosy:
+ kj
messages:
+ msg408612
keywords:
- patch |
2021-10-22 20:24:28 | erlendaasland | set | messages:
+ msg404820 |
2021-10-07 02:48:56 | Dennis Sweeney | set | pull_requests:
- pull_request27076 |
2021-10-05 05:03:10 | Dennis Sweeney | set | nosy:
+ Dennis Sweeney
pull_requests:
+ pull_request27076 stage: needs patch -> patch review |
2021-09-21 08:53:33 | sobolevn | set | nosy:
+ sobolevn messages:
+ msg402294
|
2021-09-07 16:41:26 | iritkatriel | link | issue34262 superseder |
2021-08-17 17:01:50 | vstinner | set | messages:
+ msg399770 |
2021-06-24 16:56:06 | erlendaasland | set | nosy:
+ erlendaasland messages:
+ msg396503
|
2021-06-24 16:55:23 | erlendaasland | link | issue44506 superseder |
2021-06-21 12:23:47 | vstinner | set | messages:
+ msg396238 |
2021-04-27 12:28:11 | ncoghlan | set | stage: patch review -> needs patch |
2021-04-27 12:27:58 | ncoghlan | set | nosy:
+ ncoghlan messages:
+ msg392061
|
2021-04-27 12:26:45 | ncoghlan | set | pull_requests:
- pull_request24157 |
2021-04-15 12:53:39 | vstinner | set | nosy:
+ terry.reedy
|
2021-04-15 12:53:32 | vstinner | set | title: test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure -> [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure |
2021-04-15 12:53:11 | vstinner | set | messages:
+ msg391134 |
2021-04-15 12:53:00 | vstinner | link | issue43539 superseder |
2021-04-15 12:52:37 | vstinner | link | issue42124 superseder |
2021-04-15 12:51:33 | vstinner | set | keywords:
+ patch nosy:
+ vstinner
pull_requests:
+ pull_request24157 stage: patch review |
2020-09-01 01:51:47 | aeros | set | nosy:
- paul.moore, tim.golden, zach.ware, steve.dower
|
2020-09-01 01:51:13 | aeros | set | nosy:
+ paul.moore, tim.golden, zach.ware, steve.dower components:
+ Windows, asyncio
|
2020-09-01 01:36:41 | aeros | set | messages:
+ msg376176 |
2020-09-01 01:26:06 | aeros | set | nosy:
+ asvetlov, yselivanov
type: behavior components:
+ Tests versions:
+ Python 3.10 |
2020-09-01 01:24:09 | aeros | set | messages:
+ msg376175 title: test_asyncio: Proactor -> test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure |
2020-09-01 01:20:55 | aeros | create | |