classification
Title: "will be returned as unicode" reminiscent from Python 2
Type: Stage: patch review
Components: Documentation Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Chitrank-Dixit, Wicken, cheryl.sabella, docs@python, dorosch, mdk, sumagnadas
Priority: normal Keywords: easy, newcomer friendly, patch

Created on 2020-02-21 15:58 by mdk, last changed 2020-10-02 19:21 by sumagnadas.

Pull Requests
URL Status Linked Edit
PR 18619 open dorosch, 2020-02-23 13:44
PR 18691 closed Wicken, 2020-02-28 20:01
PR 20551 closed Chitrank-Dixit, 2020-05-31 05:57
Messages (4)
msg362410 - (view) Author: Julien Palard (mdk) * (Python committer) Date: 2020-02-21 15:58
In https://docs.python.org/3/library/calendar.html#calendar.LocaleTextCalendar I read "If this locale includes an encoding all strings containing month and weekday names will be returned as unicode."

`unicode` here is a mention of the `unicode` type from Python 2 which does no longer exists, so the whole sentence can just be removed.

It happen also in the next paragraph, and twice in Lib/calendar.py.

In Python 2:

>>> print type(calendar.LocaleTextCalendar(locale="C").formatmonth(2020, 1))
<type 'str'>
>>> print type(calendar.LocaleTextCalendar(locale="en_US.UTF8").formatmonth(2020, 1))
<type 'unicode'>

In Python 3:

>>> print(type(calendar.LocaleTextCalendar(locale="C").formatmonth(2020, 1)))
<class 'str'>
>>> print(type(calendar.LocaleTextCalendar(locale="en_US.UTF8").formatmonth(2020, 1)))
<class 'str'>
msg370412 - (view) Author: Chitrank-Dixit (Chitrank-Dixit) * Date: 2020-05-31 04:36
I would like to take this issue.
msg371452 - (view) Author: Cheryl Sabella (cheryl.sabella) * (Python committer) Date: 2020-06-13 12:03
@Chitrank-Dixit, thank you for your interest in contributing to CPython.  When looking for an issue to work on, please check that a pull request isn't already open against it.  If there is an open PR, you can contribute by doing a code review.  Please refer to this[1] section of the devguide for tips on reviewing a pull request.

[1] https://devguide.python.org/pullrequest/?highlight=review#leaving-a-pull-request-review-on-github
msg377830 - (view) Author: Sumagna Das (sumagnadas) Date: 2020-10-02 19:21
Can i take on this issue? If yes, what am I supposed to do except for removing those lines which are mentioned?
History
Date User Action Args
2020-10-02 19:21:09sumagnadassetnosy: + sumagnadas
messages: + msg377830
2020-06-13 12:03:19cheryl.sabellasetnosy: + cheryl.sabella
messages: + msg371452
2020-05-31 05:57:51Chitrank-Dixitsetpull_requests: + pull_request19795
2020-05-31 04:36:58Chitrank-Dixitsetnosy: + Chitrank-Dixit
messages: + msg370412
2020-02-28 20:01:15Wickensetpull_requests: + pull_request18053
2020-02-28 20:00:10Wickensetpull_requests: - pull_request18050
2020-02-28 19:57:51Wickensetnosy: + Wicken
pull_requests: + pull_request18050
2020-02-23 13:44:29doroschsetkeywords: + patch
nosy: + dorosch

pull_requests: + pull_request17984
stage: needs patch -> patch review
2020-02-22 21:00:22terry.reedysetkeywords: + newcomer friendly
stage: needs patch
versions: + Python 3.7, Python 3.8, Python 3.9
2020-02-21 15:58:28mdkcreate