classification
Title: Deprecate explicit loop parameter in all public asyncio APIs
Type: enhancement Stage: patch review
Components: asyncio, Documentation Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: asvetlov, docs@python, dtrauma, eamanu, mbussonn, miss-islington, yselivanov
Priority: normal Keywords: patch

Created on 2019-03-19 19:55 by dtrauma, last changed 2019-06-10 23:39 by eamanu.

Pull Requests
URL Status Linked Edit
PR 13670 open eamanu, 2019-05-30 00:50
PR 13671 merged eamanu, 2019-05-30 01:43
PR 13833 merged miss-islington, 2019-06-05 05:46
PR 13920 open eamanu, 2019-06-08 17:49
PR 13950 open eamanu, 2019-06-10 23:39
Messages (13)
msg338406 - (view) Author: (dtrauma) Date: 2019-03-19 19:55
https://docs.python.org/3.7/library/asyncio-task.html#running-tasks-concurrently

For asyncio.gather, the docs should probably say

The loop argument is deprecated and scheduled for removal in Python 3.10.

as they do for all the other loop arguments of other functions.
msg338452 - (view) Author: Emmanuel Arias (eamanu) * Date: 2019-03-20 10:15
Hi,

Reading the asyncio.gather code not seem to be deprecrated.
loop is used on a lot of line of code. 

Maybe, the deprecate idea is on other place where I don't know.
msg338984 - (view) Author: (dtrauma) Date: 2019-03-27 20:41
Just to be clear, I don't know if loop is deprecated on this function like on all the others, I just suspect it to be. But it currently is completely undocumented, which either way is a bug. :)
msg338985 - (view) Author: Emmanuel Arias (eamanu) * Date: 2019-03-27 20:52
@dtrauma jus for clarify. You say that if loop is not deprecated document it else document it.


Right?
msg338986 - (view) Author: (dtrauma) Date: 2019-03-27 20:54
Yes, exactly, document deprecation status XOR what it does :)
msg343809 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-05-28 17:50
*Passing* loop to gather should be deprecated.

*Using* loop by *internal logic* is pretty fine, we do it in asyncio everywhere.

Yuri, I think we should deprecate explicit loop everywhere in non-deprecated asyncio API by Python 3.8.

We can do it even in Python beta I think.
msg343810 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2019-05-28 17:52
> Yuri, I think we should deprecate explicit loop everywhere in non-deprecated asyncio API by Python 3.8.

+1
msg343882 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-05-29 12:14
A champion is welcome :)
msg343887 - (view) Author: Emmanuel Arias (eamanu) * Date: 2019-05-29 14:43
hello, I will work on it, if there are no objection. :-)
msg343888 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2019-05-29 14:47
Thank you.

The change is pretty straightforward.

There is no need to jumbo PR, you can split the work into PR-per-module if it is more comfortable to you.

I'm ok with reviewing any approach.
msg343889 - (view) Author: Emmanuel Arias (eamanu) * Date: 2019-05-29 14:52
Hi
> There is no need to jumbo PR, you can split the work into PR-per-module if it is more comfortable to you.
Yes, I think that is better split I will try it.
> I'm ok with reviewing any approach.
Thanks!
msg344673 - (view) Author: miss-islington (miss-islington) Date: 2019-06-05 05:45
New changeset 6d64a8f49eb321116f585c4b036c81bb976d2d5c by Miss Islington (bot) (Emmanuel Arias) in branch 'master':
bpo-36373:  Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671)
https://github.com/python/cpython/commit/6d64a8f49eb321116f585c4b036c81bb976d2d5c
msg344674 - (view) Author: miss-islington (miss-islington) Date: 2019-06-05 06:01
New changeset 8899b11b95f08e2e03478f2acad336ad5933a2d1 by Miss Islington (bot) in branch '3.8':
bpo-36373:  Deprecate explicit loop parameter in all public asyncio APIs [streams] (GH-13671)
https://github.com/python/cpython/commit/8899b11b95f08e2e03478f2acad336ad5933a2d1
History
Date User Action Args
2019-06-10 23:39:36eamanusetpull_requests: + pull_request13818
2019-06-08 17:49:25eamanusetpull_requests: + pull_request13793
2019-06-05 06:01:04miss-islingtonsetmessages: + msg344674
2019-06-05 05:46:20miss-islingtonsetpull_requests: + pull_request13712
2019-06-05 05:45:57miss-islingtonsetnosy: + miss-islington
messages: + msg344673
2019-05-30 01:43:11eamanusetpull_requests: + pull_request13560
2019-05-30 00:50:45eamanusetkeywords: + patch
stage: patch review
pull_requests: + pull_request13559
2019-05-29 14:55:09asvetlovsettitle: asyncio.gather: no docs for deprecated loop parameter -> Deprecate explicit loop parameter in all public asyncio APIs
2019-05-29 14:52:48eamanusetmessages: + msg343889
title: Deprecate explicit loop parameter in all public asyncio APIs -> asyncio.gather: no docs for deprecated loop parameter
2019-05-29 14:50:49asvetlovsetversions: + Python 3.8, - Python 3.7
2019-05-29 14:50:43asvetlovsettitle: asyncio.gather: no docs for deprecated loop parameter -> Deprecate explicit loop parameter in all public asyncio APIs
2019-05-29 14:47:52asvetlovsetmessages: + msg343888
2019-05-29 14:43:34eamanusetmessages: + msg343887
2019-05-29 12:14:34asvetlovsetmessages: + msg343882
2019-05-28 23:47:37mbussonnsetnosy: + mbussonn
2019-05-28 17:52:43yselivanovsetmessages: + msg343810
2019-05-28 17:50:25asvetlovsetmessages: + msg343809
2019-03-27 20:54:16dtraumasetmessages: + msg338986
2019-03-27 20:52:44eamanusetmessages: + msg338985
2019-03-27 20:41:06dtraumasetmessages: + msg338984
2019-03-20 10:15:50eamanusetnosy: + eamanu
messages: + msg338452
2019-03-20 02:47:58xtreaksetnosy: + asvetlov, yselivanov
components: + asyncio
2019-03-19 19:55:35dtraumacreate