classification
Title: clean out some more AtheOS code
Type: Stage: resolved
Components: Versions: Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: benjamin.peterson, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2017-10-25 06:20 by benjamin.peterson, last changed 2017-10-26 06:55 by benjamin.peterson. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 4115 merged benjamin.peterson, 2017-10-25 06:22
Messages (4)
msg304963 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-10-25 06:20
We stopped support AtheOS in 2007. But, there are still references in the code:

$ git grep -i AtheOS
Doc/whatsnew/2.3.rst:Other new platforms now supported by Python include AtheOS
Doc/whatsnew/2.3.rst:(http://atheos.cx/), GNU/Hurd, and OpenVMS.
Lib/distutils/command/build_ext.py:        # for extensions under Cygwin and AtheOS Python's library directory must be
Lib/distutils/command/build_ext.py:        if sys.platform[:6] == 'cygwin' or sys.platform[:6] == 'atheos':
Lib/distutils/command/build_ext.py:        elif sys.platform[:6] == "atheos":
Lib/test/test_os.py:            # On AtheOS, glibc always returns ENOSYS
Lib/test/test_os.py:            # On AtheOS, glibc always returns ENOSYS
Misc/HISTORY:- Support for AtheOS has been completely removed from the code base. It was
Misc/HISTORY:- Support for BeOS and AtheOS was removed (according to PEP 11).
Misc/HISTORY:- AtheOS is now supported.
Modules/_cryptmodule.c:    /* On some platforms (AtheOS) crypt returns NULL for an invalid
config.guess:    i*86:atheos:*:*)
config.guess:   echo ${UNAME_MACHINE}-unknown-atheos
config.sub:     -atheos*)
config.sub:             os=-atheos
configure:atheos*|Linux*/1*)
configure.ac:atheos*|Linux*/1*)
msg304964 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2017-10-25 07:01
What about configure.ac?

"On some platforms (AtheOS)" in the comment in Modules/_cryptmodule.c is redundant. crypt() should return NULL on error, and it often returns NULL for an invalid salt.
msg305025 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-10-26 06:04
Well, the configure.ac thing is some code that fails if you're running atheos.
msg305027 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2017-10-26 06:55
New changeset 4eaf7f949069882e385f2297c9e70031caf9144c by Benjamin Peterson in branch 'master':
fixes bpo-31866: remove code pertaining to AtheOS support (#4115)
https://github.com/python/cpython/commit/4eaf7f949069882e385f2297c9e70031caf9144c
History
Date User Action Args
2017-10-26 06:55:16benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg305027

stage: patch review -> resolved
2017-10-26 06:04:13benjamin.petersonsetmessages: + msg305025
2017-10-25 07:01:02serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg304964
2017-10-25 06:22:15benjamin.petersonsetkeywords: + patch
stage: patch review
pull_requests: + pull_request4085
2017-10-25 06:20:23benjamin.petersoncreate