classification
Title: Use test.script_helper.assert_python_ok() instead of subprocess.* in test.test_warnings
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: pitrou Nosy List: Arfrever, pitrou, python-dev
Priority: normal Keywords: patch

Created on 2014-01-24 02:49 by Arfrever, last changed 2014-01-29 22:45 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
python-2.7-test_warnings.py_use_assert_python_ok.patch Arfrever, 2014-01-24 02:49 Patch for 2.7 branch
python-3.3-test_warnings.py_use_assert_python_ok.patch Arfrever, 2014-01-24 02:50 Patch for 3.3 branch
Messages (4)
msg209030 - (view) Author: Arfrever Frehtes Taifersar Arahesis (Arfrever) * (Python triager) Date: 2014-01-24 02:49
These patches make test.test_warnings use test.script_helper.assert_python_ok() instead of subprocess.*, as suggested by Antoine in msg209022.
msg209688 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-01-29 22:41
There's not much point in changing the 2.7 tests at this point. It's reasonable to change both 3.3 and 3.x, so as to avoid divergence.
msg209689 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-01-29 22:45
New changeset d844b31471b5 by Antoine Pitrou in branch '3.3':
Issue #20373: generalize use of test.script_helper in test_warnings.  Patch by Arfrever.
http://hg.python.org/cpython/rev/d844b31471b5

New changeset 04b658b3fe7c by Antoine Pitrou in branch 'default':
Issue #20373: generalize use of test.script_helper in test_warnings.  Patch by Arfrever.
http://hg.python.org/cpython/rev/04b658b3fe7c
msg209690 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-01-29 22:45
Thanks for the patch!
History
Date User Action Args
2014-01-29 22:45:36pitrousetstatus: open -> closed
resolution: fixed
messages: + msg209690

stage: patch review -> resolved
2014-01-29 22:45:15python-devsetnosy: + python-dev
messages: + msg209689
2014-01-29 22:41:25pitrousetmessages: + msg209688
2014-01-29 22:40:53pitrousetversions: - Python 2.7
2014-01-24 02:52:24Arfreverlinkissue20355 dependencies
2014-01-24 02:50:36Arfreversetfiles: + python-3.3-test_warnings.py_use_assert_python_ok.patch
2014-01-24 02:49:19Arfrevercreate