Message209022
About the patch (note the code review tool hasn't accepted it, so I'm commenting here):
- in the tests, I think comparing stderr as-is will fail under Windows, where the line separator is b"\r\n"; better call splitlines() first
- in the tests, I think it would be better to use test.script_helper.assert_python_ok() (it will automate some stuff for you), even though other tests don't in that file
- in main.c, you need to Py_DECREF warning_options when you are done with it. |
|
Date |
User |
Action |
Args |
2014-01-23 23:30:24 | pitrou | set | recipients:
+ pitrou, barry, brett.cannon, larry, pjenvey, eric.araujo, Arfrever, brian.curtin, skrah |
2014-01-23 23:30:24 | pitrou | set | messageid: <1390519824.55.0.0736397499148.issue20355@psf.upfronthosting.co.za> |
2014-01-23 23:30:24 | pitrou | link | issue20355 messages |
2014-01-23 23:30:23 | pitrou | create | |
|