Author pitrou
Recipients Arfrever, barry, brett.cannon, brian.curtin, eric.araujo, larry, pitrou, pjenvey, skrah
Date 2014-01-23.23:30:23
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390519824.55.0.0736397499148.issue20355@psf.upfronthosting.co.za>
In-reply-to
Content
About the patch (note the code review tool hasn't accepted it, so I'm commenting here):
- in the tests, I think comparing stderr as-is will fail under Windows, where the line separator is b"\r\n"; better call splitlines() first
- in the tests, I think it would be better to use test.script_helper.assert_python_ok() (it will automate some stuff for you), even though other tests don't in that file
- in main.c, you need to Py_DECREF warning_options when you are done with it.
History
Date User Action Args
2014-01-23 23:30:24pitrousetrecipients: + pitrou, barry, brett.cannon, larry, pjenvey, eric.araujo, Arfrever, brian.curtin, skrah
2014-01-23 23:30:24pitrousetmessageid: <1390519824.55.0.0736397499148.issue20355@psf.upfronthosting.co.za>
2014-01-23 23:30:24pitroulinkissue20355 messages
2014-01-23 23:30:23pitroucreate