classification
Title: Increased test coverage for telnetlib
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: Alex.Volkov, ezio.melotti, python-dev
Priority: normal Keywords: patch

Created on 2013-08-25 18:38 by Alex.Volkov, last changed 2013-08-25 21:19 by ezio.melotti. This issue is now closed.

Files
File name Uploaded Description Edit
test_telnetlib_getter.patch Alex.Volkov, 2013-08-25 18:38 review
Messages (3)
msg196158 - (view) Author: Alex Volkov (Alex.Volkov) * Date: 2013-08-25 18:38
This issue splits up an unrelated patch from issue 18731
http://bugs.python.org/issue18731

Added a test for telnetlib increasing test coverage.

Updated with the changes from code review of issue 18731
http://bugs.python.org/review/18731/patch/8923/33000
msg196164 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-25 21:17
New changeset 6b33d786b46d by Ezio Melotti in branch '2.7':
#18833: add a test for test_telnetlib.  Patch by Alex Volkov.
http://hg.python.org/cpython/rev/6b33d786b46d

New changeset 1b42e483e520 by Ezio Melotti in branch '3.3':
#18833: add a test for test_telnetlib.  Patch by Alex Volkov.
http://hg.python.org/cpython/rev/1b42e483e520

New changeset a4ec11e0fb87 by Ezio Melotti in branch 'default':
#18833: merge with 3.3.
http://hg.python.org/cpython/rev/a4ec11e0fb87
msg196165 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-25 21:19
Fixed, thanks for the report and the patch!

Could you also sign the contributor agreement?
http://www.python.org/psf/contrib/contrib-form/
History
Date User Action Args
2013-08-25 21:19:31ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 2.7, Python 3.3
nosy: + ezio.melotti

messages: + msg196165
resolution: fixed
stage: resolved
2013-08-25 21:17:51python-devsetnosy: + python-dev
messages: + msg196164
2013-08-25 18:38:21Alex.Volkovcreate