➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Increased test coverage for uu and telnet
Type: enhancement Stage: patch review
Components: Tests Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: Alex.Volkov, ezio.melotti, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2013-08-13 21:04 by Alex.Volkov, last changed 2022-04-11 14:57 by admin.

Files
File name Uploaded Description Edit
telnet_uu_tests.patch Alex.Volkov, 2013-08-13 21:04 review
uu_test_v2.patch Alex.Volkov, 2013-08-27 22:44 review
Messages (2)
msg196325 - (view) Author: Alex Volkov (Alex.Volkov) * Date: 2013-08-27 22:44 
Okay,

I'm submitting the patch just for uu / test_uu.

I replaced all try/finally statemets with 'with' context, added try..finally statement for both test cases.

uu.py, line 61 is exposed by test_encode_osstat_assert -- os.stat is duckpunched out of the system, then test case verifies that default permissions(666) is written into a file.

I didn't have try...finally statement because I wasn't sure how the test case will behave when inner try..finally is triggered, so far the tests seem to pass..
msg231357 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-19 07:42 
test_encode_defaults is failed now. Don't use hardcoded filename length.

And I don't understand the purpose of changes in uu.py.
History
Date User Action Args
2022-04-11 14:57:49adminsetgithub: 62931
2014-11-19 07:42:26serhiy.storchakasetmessages: + msg231357
versions: + Python 2.7, Python 3.5
2013-09-13 21:26:37ezio.melottisetnosy: + serhiy.storchaka
2013-08-27 22:44:21Alex.Volkovsetfiles: + uu_test_v2.patch

messages: + msg196325
2013-08-16 20:29:19ezio.melottisetnosy: + ezio.melotti
2013-08-14 12:31:31pitrousetstage: patch review
2013-08-13 21:04:22Alex.Volkovcreate