classification
Title: Deprecate sys._mercurial and create sys._git
Type: Stage: patch review
Components: Library (Lib) Versions: Python 3.7, Python 3.6, Python 3.5, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: benjamin.peterson, brett.cannon, larry, matrixise, ned.deily, steve.dower
Priority: release blocker Keywords: patch

Created on 2016-07-22 21:43 by brett.cannon, last changed 2017-02-23 22:13 by steve.dower.

Files
File name Uploaded Description Edit
issue27593.diff brett.cannon, 2016-09-10 18:49 review
issue27593-with-indent-3.7.diff matrixise, 2016-10-20 15:00 review
issue27593-with-indent-3.7-2.diff matrixise, 2016-10-20 16:44 review
Pull Requests
URL Status Linked Edit
PR 262 open steve.dower, 2017-02-23 22:12
Messages (14)
msg271037 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-07-22 21:43
This is part of the GitHub migration. And by "deprecate" sys._mercurial I mean fill it with default values (https://www.python.org/dev/peps/pep-0512/#deprecate-sys-mercurial).
msg275524 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-09-10 01:12
Get the current branch: `git rev-parse --abbrev-ref HEAD`
msg275525 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-09-10 01:13
Get the current revision: `git rev-parse HEAD`
msg275544 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-09-10 02:27
https://github.com/python/cpython/blob/master/Modules/getbuildinfo.c will need to be updated on top of configure.ac and Makefile.pre.in.
msg275671 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-09-10 18:49
Here is a patch to add sys._git and update Py_GetBuildInfo() as necessary. I would like to see this in Python 3.6 as 3.6.0 will be released using Mercurial but (hopefully) subsequent releases will be on git, so any reviews will be appreciated.

I will hold off on removing sys._mercurial until 3.7 as that will be the first release that doesn't span version control systems.
msg275825 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-09-11 18:13
Thanks for the patch, Brett.  Having done a quick test, I'd like to review this in more detail before applying but that will have to wait until after b1.  If you want, you can reassign this to me.
msg275831 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-09-11 19:05
Sounds good.

On Sun, Sep 11, 2016, 11:13 Ned Deily <report@bugs.python.org> wrote:

>
> Ned Deily added the comment:
>
> Thanks for the patch, Brett.  Having done a quick test, I'd like to review
> this in more detail before applying but that will have to wait until after
> b1.  If you want, you can reassign this to me.
>
> ----------
> priority: release blocker -> deferred blocker
> stage:  -> patch review
> versions: +Python 3.7
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue27593>
> _______________________________________
>
msg279037 - (view) Author: St├ęphane Wirtel (matrixise) * Date: 2016-10-20 15:00
Hello Brett,

after my review, I propose this patch where I have added the missing indents and remove the ./configure file (because this one can be generated by autoreconf)
msg279044 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2016-10-20 16:38
The inclusion of changes to ./configure is on purpose since the file is in the repository and not everyone has autoconf installed to necessarily re-generate the file (and we have had issues with people using really old versions of autoconf in the past).
msg279045 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-10-20 16:40
I'll get to this one shortly.
msg279046 - (view) Author: St├ęphane Wirtel (matrixise) * Date: 2016-10-20 16:44
Hi Brett,

With your comment, I have added the modified ./configure.

Here is the last patch including the indentation.
msg287715 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-02-13 17:40
This is now blocking all releases for all versions.

I'll try and make some time to update the Windows build scripts and project files, but if someone else gets there first feel free to post a PR.
msg287725 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2017-02-13 21:14
Yeah, I'll get to the non-Windows parts shortly.  I'd been waiting for the transition to happen.
msg288490 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2017-02-23 22:13
It looks to me like we want:

branch=`git name-rev --name-only HEAD`
revision=`git rev-parse HEAD`
tag=`git name-rev --tags --name-only HEAD`

Unless we're planning on leaving out the tag?

My PR 262 makes the Windows build changes in master, but doesn't change getbuildinfo.c.
History
Date User Action Args
2017-02-23 22:13:17steve.dowersetmessages: + msg288490
2017-02-23 22:12:31steve.dowersetpull_requests: + pull_request234
2017-02-13 21:14:39ned.deilysetmessages: + msg287725
2017-02-13 17:40:58steve.dowersetpriority: deferred blocker -> release blocker
versions: + Python 2.7, Python 3.5
nosy: + larry, benjamin.peterson, steve.dower

messages: + msg287715
2016-10-20 16:44:31matrixisesetfiles: + issue27593-with-indent-3.7-2.diff

messages: + msg279046
2016-10-20 16:40:53ned.deilysetassignee: brett.cannon -> ned.deily
messages: + msg279045
2016-10-20 16:38:24brett.cannonsetmessages: + msg279044
2016-10-20 15:00:14matrixisesetfiles: + issue27593-with-indent-3.7.diff
nosy: + matrixise
messages: + msg279037

2016-09-11 19:05:30brett.cannonsetmessages: + msg275831
2016-09-11 18:13:11ned.deilysetpriority: release blocker -> deferred blocker

stage: patch review
messages: + msg275825
versions: + Python 3.7
2016-09-10 18:49:59brett.cannonsetfiles: + issue27593.diff
priority: normal -> release blocker

versions: + Python 3.6
keywords: + patch
nosy: + ned.deily

messages: + msg275671
2016-09-10 02:27:22brett.cannonsetmessages: + msg275544
2016-09-10 01:13:43brett.cannonsetmessages: + msg275525
2016-09-10 01:12:51brett.cannonsetassignee: brett.cannon
messages: + msg275524
2016-07-22 21:43:25brett.cannoncreate