Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1982)

#27593: Deprecate sys._mercurial and create sys._git

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by brett
Modified:
8 months, 1 week ago
Reviewers:
stephane
CC:
brett.cannon, haypo, larry, Benjamin Peterson, ned.deily, steve.dower, matrixise
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/pylifecycle.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
Makefile.pre.in View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
Modules/getbuildinfo.c View 1 2 2 chunks +35 lines, -7 lines 0 comments Download
Python/sysmodule.c View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
configure View 1 2 7 chunks +59 lines, -13 lines 0 comments Download
configure.ac View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 1
matrixise
8 months, 1 week ago #1
Hello Brett, I have added some comments but I am going to propose a patch.

Stephane

http://bugs.python.org/review/27593/diff/18472/Makefile.pre.in
File Makefile.pre.in (right):

http://bugs.python.org/review/27593/diff/18472/Makefile.pre.in#newcode46
Makefile.pre.in:46: GITVERSION= @GITVERSION@
you don't keep the indentation

http://bugs.python.org/review/27593/diff/18472/Makefile.pre.in#newcode740
Makefile.pre.in:740: -DGITVERSION="\"`LC_ALL=C $(GITVERSION)`\"" \
keep the indentation

http://bugs.python.org/review/27593/diff/18472/configure.ac
File configure.ac (right):

http://bugs.python.org/review/27593/diff/18472/configure.ac#newcode54
configure.ac:54: AC_CHECK_PROG(HAS_GIT, git, found, not-found)
Indentation

http://bugs.python.org/review/27593/diff/18472/configure.ac#newcode56
configure.ac:56: HAS_GIT=no-repository
indentation
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7