This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Duplicate function names in test_email.py
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.3, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ezio.melotti Nosy List: ezio.melotti, python-dev, r.david.murray, vajrasky
Priority: normal Keywords:

Created on 2013-07-19 16:22 by vajrasky, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
fix_duplicate_function_names.txt vajrasky, 2013-07-19 16:22 review
Messages (3)
msg193366 - (view) Author: Vajrasky Kok (vajrasky) * Date: 2013-07-19 16:22
In Lib/test/test_email/test_email.py,

Part 1: line 4210 and 4217 have same function name, which is test_encode_one_long_line. In fact, they have same function body!

    def test_encode_one_long_line(self):
        self._test_encode('x' * 100 + '\n', 'x' * 75 + '=\n' + 'x' * 25 + '\n')

One of them can be removed.

Part 2: line 928 and 1009 have same function name, which is test_splitter_split_on_punctuation_only_if_fws. This time, they have different function body and one of them (line 928) is overshadowed (not being executed by unit test) by the other. So we must rename one of them.
msg194811 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-08-10 15:58
New changeset 53d54503fc06 by Ezio Melotti in branch '3.3':
#18505: fix duplicate name and remove duplicate test.  Patch by Vajrasky Kok.
http://hg.python.org/cpython/rev/53d54503fc06

New changeset cb0fba5c7828 by Ezio Melotti in branch 'default':
#18505: merge with 3.3.
http://hg.python.org/cpython/rev/cb0fba5c7828
msg194812 - (view) Author: Ezio Melotti (ezio.melotti) * (Python committer) Date: 2013-08-10 15:58
Fixed, thanks for the report and the patch!
History
Date User Action Args
2022-04-11 14:57:48adminsetgithub: 62705
2013-08-10 15:58:38ezio.melottisetstatus: open -> closed

type: enhancement
assignee: ezio.melotti
versions: + Python 3.3
nosy: + ezio.melotti

messages: + msg194812
resolution: fixed
stage: resolved
2013-08-10 15:58:07python-devsetnosy: + python-dev
messages: + msg194811
2013-07-19 16:22:41vajraskycreate