Author yorick
Recipients d_kagedal, fpmc, gregory.p.smith, mkc, yorick
Date 2009-03-31.15:00:47
SpamBayes Score 1.44695e-06
Marked as misclassified No
Message-id <1238511649.1.0.831730615213.issue3392@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks all right in general. I would use something like

if "poll" in dir(select)

instead of catching AttributeError which risks hiding bugs in 
_communicate_with_poll().

PEP8 probably wants spaces around the bitwise-or operator.

Some systems cannot use TTYs in poll(2) but this should not be a 
problem here - there is no point in using .communicate() with stdin/
stdout/stderr set to anything but PIPE, right?
History
Date User Action Args
2009-03-31 15:00:49yoricksetrecipients: + yorick, gregory.p.smith, mkc, d_kagedal, fpmc
2009-03-31 15:00:49yoricksetmessageid: <1238511649.1.0.831730615213.issue3392@psf.upfronthosting.co.za>
2009-03-31 15:00:47yoricklinkissue3392 messages
2009-03-31 15:00:47yorickcreate