Author davin
Recipients brett.cannon, davin, eric.snow, giampaolo.rodola, lukasz.langa, nascheme, osvenskan, pitrou, pmpp, rhettinger, ronaldoussoren, skrah, terry.reedy, yselivanov
Date 2019-02-11.06:22:39
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549866159.91.0.87768873982.issue35813@roundup.psfhosted.org>
In-reply-to
Content
@giampaolo.rodola: Your patch from 3 days ago in issue35917 included additional tests around the SharedMemoryManager which are now causing test failures in my new PR.  This is my fault because I altered SharedMemoryManager to no longer support functionality from SyncManager that I thought could be confusing to include.  I am just now discovering this and am not immediately sure if simply removing the SharedMemoryManager-relevant lines from your patch is the right solution but I wanted to mention this thought right away.

Thank you for discovering that SyncManager was being overlooked in the tests and the nice patch in issue35917.
History
Date User Action Args
2019-02-11 06:22:40davinsetrecipients: + davin, brett.cannon, nascheme, rhettinger, terry.reedy, ronaldoussoren, pitrou, osvenskan, giampaolo.rodola, skrah, pmpp, lukasz.langa, eric.snow, yselivanov
2019-02-11 06:22:39davinsetmessageid: <1549866159.91.0.87768873982.issue35813@roundup.psfhosted.org>
2019-02-11 06:22:39davinlinkissue35813 messages
2019-02-11 06:22:39davincreate