classification
Title: multiprocessing: provide unit-tests for manager classes and shareable types
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.8, Python 3.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: davin, giampaolo.rodola, pitrou
Priority: normal Keywords: patch, patch, patch

Created on 2019-02-06 16:35 by giampaolo.rodola, last changed 2019-02-07 11:34 by pitrou. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 11772 merged giampaolo.rodola, 2019-02-06 16:47
PR 11772 merged giampaolo.rodola, 2019-02-06 16:47
PR 11772 merged giampaolo.rodola, 2019-02-06 16:47
PR 11780 merged pitrou, 2019-02-07 11:09
PR 11780 merged pitrou, 2019-02-07 11:09
PR 11780 merged pitrou, 2019-02-07 11:09
Messages (6)
msg334952 - (view) Author: Giampaolo Rodola' (giampaolo.rodola) * (Python committer) Date: 2019-02-06 16:35
This is a follow up of BPO-35813 and PR-11664 and it provides unit tests for SyncManager and SharedMemoryManager classes + all the shareable types which are supposed to be supported by them. Also, see relevant python-dev discussion at: https://mail.python.org/pipermail/python-dev/2019-February/156235.html.

In doing so I discovered a couple of issues which I will treat in a separate BPO ticket (multiprocessing.managers's dict.has_key() and Pool() appear to be broken).
msg334954 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2019-02-06 16:50
Interesting.  I had never looked too closely and assumed this was already tested.
msg334955 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2019-02-06 16:51
Would probably be worthwhile backporting to 3.7 as well.
msg335010 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2019-02-07 11:03
New changeset 2848d9d29914948621bce26bf0d9a89f2e19b97b by Antoine Pitrou (Giampaolo Rodola) in branch 'master':
bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772)
https://github.com/python/cpython/commit/2848d9d29914948621bce26bf0d9a89f2e19b97b
msg335011 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2019-02-07 11:34
New changeset 15526f5be72f547288c16d53526fc74f15ee61ed by Antoine Pitrou in branch '3.7':
[3.7] bpo-35917: Test multiprocessing manager classes and shareable types (GH-11772) (GH-11780)
https://github.com/python/cpython/commit/15526f5be72f547288c16d53526fc74f15ee61ed
msg335012 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2019-02-07 11:34
Thanks Giampaolo!
History
Date User Action Args
2019-02-07 11:34:54pitrousetstatus: open -> closed
messages: + msg335012

keywords: patch, patch, patch
resolution: fixed
stage: patch review -> resolved
2019-02-07 11:34:16pitrousetmessages: + msg335011
2019-02-07 11:09:35pitrousetpull_requests: + pull_request11763
2019-02-07 11:09:28pitrousetpull_requests: + pull_request11762
2019-02-07 11:09:20pitrousetpull_requests: + pull_request11761
2019-02-07 11:03:24pitrousetmessages: + msg335010
2019-02-06 16:51:04pitrousetkeywords: patch, patch, patch

messages: + msg334955
versions: + Python 3.7
2019-02-06 16:50:37pitrousetkeywords: patch, patch, patch

messages: + msg334954
2019-02-06 16:47:17giampaolo.rodolasetkeywords: + patch
pull_requests: + pull_request11742
2019-02-06 16:47:12giampaolo.rodolasetkeywords: + patch
pull_requests: + pull_request11741
2019-02-06 16:47:07giampaolo.rodolasetkeywords: + patch
pull_requests: + pull_request11740
2019-02-06 16:44:50terry.reedysetnosy: + pitrou, davin
2019-02-06 16:35:19giampaolo.rodolacreate