Author terry.reedy
Recipients louielu, terry.reedy
Date 2017-06-14.19:40:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1497469217.72.0.289046216415.issue30632@psf.upfronthosting.co.za>
In-reply-to
Content
Ping.  Please answer question about two PRs.

For #30666, I wrote
1. Test_autocomplete.AutoCompleteTest has a test_method for each method of autocomplete.AutoComplete.  The last 5 test methods are empty ('pass'). Finish them.  A couple of the methods might be usefully split into smaller methods.  Get_entity is actually a function, as 'self' is ignored. After the first else, fetch_completions is also independent of 'self'.  PR 2011 combines the two blocks into a function that can be moved to run.py.

These method tests should be supplemented by user action tests with live widgets and simulated key events.  Such tests would be black box tests in that they should be independent of the implementation.

I decided to broaden this issue to all autocomplete tests and narrow that one to autocomplete_w tests.
History
Date User Action Args
2017-06-14 19:40:17terry.reedysetrecipients: + terry.reedy, louielu
2017-06-14 19:40:17terry.reedysetmessageid: <1497469217.72.0.289046216415.issue30632@psf.upfronthosting.co.za>
2017-06-14 19:40:17terry.reedylinkissue30632 messages
2017-06-14 19:40:17terry.reedycreate