Message292847
Your patch LGTM as a minimal patch for backporting to maintained releases (maybe Mark have other comments). But I think it would be better to make all pointers to raw memory of type unsigned char*. Not just packing, but unpacking too. Using even memcpy between long* and char* is undefined behavior, the source and target should either have the same type, or one of them be unsigned char*. |
|
Date |
User |
Action |
Args |
2017-05-03 07:03:28 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, mark.dickinson, meador.inge, xiang.zhang |
2017-05-03 07:03:28 | serhiy.storchaka | set | messageid: <1493795008.11.0.935304109191.issue30242@psf.upfronthosting.co.za> |
2017-05-03 07:03:28 | serhiy.storchaka | link | issue30242 messages |
2017-05-03 07:03:27 | serhiy.storchaka | create | |
|