Author serhiy.storchaka
Recipients mark.dickinson, meador.inge, serhiy.storchaka, xiang.zhang
Date 2017-05-03.07:03:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1493795008.11.0.935304109191.issue30242@psf.upfronthosting.co.za>
In-reply-to
Content
Your patch LGTM as a minimal patch for backporting to maintained releases (maybe Mark have other comments). But I think it would be better to make all pointers to raw memory of type unsigned char*. Not just packing, but unpacking too. Using even memcpy between long* and char* is undefined behavior, the source and target should either have the same type, or one of them be unsigned char*.
History
Date User Action Args
2017-05-03 07:03:28serhiy.storchakasetrecipients: + serhiy.storchaka, mark.dickinson, meador.inge, xiang.zhang
2017-05-03 07:03:28serhiy.storchakasetmessageid: <1493795008.11.0.935304109191.issue30242@psf.upfronthosting.co.za>
2017-05-03 07:03:28serhiy.storchakalinkissue30242 messages
2017-05-03 07:03:27serhiy.storchakacreate