Author ztane
Recipients Demur Rumed, eric.smith, mjpieters, rhettinger, serhiy.storchaka, ztane
Date 2016-09-04.06:58:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1472972302.39.0.074889112638.issue27078@psf.upfronthosting.co.za>
In-reply-to
Content
Though it is clean to do like this: let _PyUnicode_JoinArray have `NULL` mean empty string, as it is more logical anyway; then PyUnicode_Join itself just needs to:

   if (separator == NULL) {
       separator = PyUnicode_FromOrdinal(' ');
       /* check omitted */
       res = _PyUnicode_JoinArray(separator, items, seqlen);
       Py_DECREF(separator);
   }
   else {
      res = _PyUnicode_JoinArray(separator, items, seqlen);
   }

The NULL argument I guess isn't that common to pass to PyUnicode_Join (Python code especially would always have to pass in ' ' instead), so this shouldn't really affect performance for any case at all.
History
Date User Action Args
2016-09-04 06:58:22ztanesetrecipients: + ztane, rhettinger, mjpieters, eric.smith, serhiy.storchaka, Demur Rumed
2016-09-04 06:58:22ztanesetmessageid: <1472972302.39.0.074889112638.issue27078@psf.upfronthosting.co.za>
2016-09-04 06:58:22ztanelinkissue27078 messages
2016-09-04 06:58:22ztanecreate