Author vstinner
Recipients igor.pashev, vstinner
Date 2014-08-23.21:27:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAMpsgwYZSYU1kPvaJ4rxq8szToUmQD_eaSkM2tD1y9wA4LOu4g@mail.gmail.com>
In-reply-to <1408801664.2.0.122717824308.issue22258@psf.upfronthosting.co.za>
Content
The patch doesn't look correct. Ioctl() reduces the overhead in term of
syscalls (1 vs 2).

What is the errno value on failure? We should remember that ioctl() doesn't
work and fallback to fcntl(). It would be more portable. Similar check is
already done for O_TMPFILE and O_CLOEXEC for example.

See the PEP 446.
History
Date User Action Args
2014-08-23 21:27:29vstinnersetrecipients: + vstinner, igor.pashev
2014-08-23 21:27:29vstinnerlinkissue22258 messages
2014-08-23 21:27:29vstinnercreate