Message154136
There were bugs in two of the updated tests:
- test_glob_to_re() was doing two levels of escaping (r'\' -> r'\\\\')
for its expected output when it should only do one (r'\' -> r'\\').
- test_process_template() was not converting some of its expected
results to use the native directory separator.
I've attached a patch that fixes these issues. I also took the liberty of
changing the checks for whether the separator needs to be escaped - it's
better to escape everything except "/", just in case someone decides to
port Python to some platform using a weird directory separator that is
neither "/" nor r"\".
With my updated patch, all tests pass on both Windows and Linux, and I've
also manually verified that the buildout.cfg problem and the
sandbox/dummy.py problem (from issue 9691) are both fixed.
Please review (and commit, if my changes are OK). |
|
Date |
User |
Action |
Args |
2012-02-24 13:41:45 | nadeem.vawda | set | recipients:
+ nadeem.vawda, georg.brandl, jaraco, cjw296, benjamin.peterson, tarek, eric.araujo, Adam.Groszer |
2012-02-24 13:41:45 | nadeem.vawda | set | messageid: <1330090905.77.0.325727368844.issue6884@psf.upfronthosting.co.za> |
2012-02-24 13:41:45 | nadeem.vawda | link | issue6884 messages |
2012-02-24 13:41:44 | nadeem.vawda | create | |
|