This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients SilentGhost, belopolsky, georg.brandl, mark.dickinson
Date 2011-01-31.17:33:42
SpamBayes Score 1.4070083e-05
Marked as misclassified No
Message-id <1296495223.12.0.91417817776.issue11081@psf.upfronthosting.co.za>
In-reply-to
Content
I would say if anything can go in after rc2 at all, this should be accepted.  George?

I ran a few sanity checks with the patch applied:

>>> set(struct.__all__) - set(dir(struct))
set()
>>> set(dir(struct)) - set(struct.__all__)
{'_clearcache', '__all__', '__builtins__', '__file__', '__package__', '__cached__', '__name__', '__doc__'}
>>> len(set(struct.__all__)) == len(struct.__all__)
True

LGTM.  Maybe one of the tests above can be converted to a unit test.
History
Date User Action Args
2011-01-31 17:33:43belopolskysetrecipients: + belopolsky, georg.brandl, mark.dickinson, SilentGhost
2011-01-31 17:33:43belopolskysetmessageid: <1296495223.12.0.91417817776.issue11081@psf.upfronthosting.co.za>
2011-01-31 17:33:42belopolskylinkissue11081 messages
2011-01-31 17:33:42belopolskycreate