➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-01-31 17:21 by SilentGhost, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| struct.py.diff | SilentGhost, 2011-01-31 17:21 | |||
| Messages (4) | |||
|---|---|---|---|
| msg127625 - (view) | Author: SilentGhost (SilentGhost) *  |
Date: 2011-01-31 17:21 | |
the following issue was introduced in r81947: >>> from struct import * >>> pack_into Traceback (most recent call last): File "<pyshell#1>", line 1, in <module> pack_into NameError: name 'pack_into' is not defined struct.__all__ has a duplicate entry for "unpack" and misses "pack_into". Patch is attached, test passes. Seems quite innocent to me, could it make into 3.2, George? Related: #8973 and #11078 |
|||
| msg127628 - (view) | Author: Alexander Belopolsky (belopolsky) *  |
Date: 2011-01-31 17:33 | |
I would say if anything can go in after rc2 at all, this should be accepted. George?
I ran a few sanity checks with the patch applied:
>>> set(struct.__all__) - set(dir(struct))
set()
>>> set(dir(struct)) - set(struct.__all__)
{'_clearcache', '__all__', '__builtins__', '__file__', '__package__', '__cached__', '__name__', '__doc__'}
>>> len(set(struct.__all__)) == len(struct.__all__)
True
LGTM. Maybe one of the tests above can be converted to a unit test.
|
|||
| msg127641 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2011-01-31 18:53 | |
Yes, this can go in. |
|||
| msg127649 - (view) | Author: Alexander Belopolsky (belopolsky) * |
Date: 2011-01-31 19:28 | |
Committed in revision 88280. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:12 | admin | set | github: 55290 |
| 2011-01-31 19:28:38 | belopolsky | set | status: open -> closed nosy: georg.brandl, mark.dickinson, belopolsky, SilentGhost messages: + msg127649 resolution: fixed stage: commit review -> resolved |
| 2011-01-31 18:53:38 | georg.brandl | set | assignee: georg.brandl -> belopolsky messages: + msg127641 nosy: georg.brandl, mark.dickinson, belopolsky, SilentGhost |
| 2011-01-31 17:35:45 | belopolsky | set | nosy:
georg.brandl, mark.dickinson, belopolsky, SilentGhost stage: commit review |
| 2011-01-31 17:35:17 | belopolsky | link | issue11078 dependencies |
| 2011-01-31 17:33:42 | belopolsky | set | assignee: georg.brandl versions: + Python 3.2, - Python 3.3 messages: + msg127628 nosy: georg.brandl, mark.dickinson, belopolsky, SilentGhost |
| 2011-01-31 17:21:58 | SilentGhost | create | |