Author belopolsky
Recipients belopolsky, flox, l0nwlf, loewis, michael.foord, orsenthil, r.david.murray, ronaldoussoren
Date 2010-05-05.18:22:55
SpamBayes Score 0.00169569
Marked as misclassified No
Message-id <1273083777.56.0.0331504181137.issue7900@psf.upfronthosting.co.za>
In-reply-to
Content
The latest patch, os-getgroups-v2.patch, seems to have the same bug as I reported in msg99926:

"""
The crash that I see is apparently due to underallocated  memory:

 alt_grouplist = PyMem_Malloc(n);

should be

 alt_grouplist = PyMem_Malloc(n * sizeof(gid_t));
"""

I no longer see the crash, but did not have a chance to investigate it further.  In any case, PyMem_Malloc(n) is clearly wrong and should be replaced by PyMem_Malloc(n * sizeof(gid_t)) or maybe better by PyMem_New(gid_t, n).

There are no tests in the patch and issue7900-tests.diff tests return "FAILED (failures=3, errors=2)" when ran as a superuser.
History
Date User Action Args
2010-05-05 18:22:57belopolskysetrecipients: + belopolsky, loewis, ronaldoussoren, orsenthil, r.david.murray, michael.foord, flox, l0nwlf
2010-05-05 18:22:57belopolskysetmessageid: <1273083777.56.0.0331504181137.issue7900@psf.upfronthosting.co.za>
2010-05-05 18:22:56belopolskylinkissue7900 messages
2010-05-05 18:22:55belopolskycreate