Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use test.script_helper.assert_python_ok() instead of subprocess.* in test.test_warnings #64572

Closed
Arfrever mannequin opened this issue Jan 24, 2014 · 4 comments
Closed

Use test.script_helper.assert_python_ok() instead of subprocess.* in test.test_warnings #64572

Arfrever mannequin opened this issue Jan 24, 2014 · 4 comments
Assignees
@pitrou
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@Arfrever
Copy link
Mannequin

Arfrever mannequin commented Jan 24, 2014

BPO 20373
Nosy @pitrou
Files
  • python-2.7-test_warnings.py_use_assert_python_ok.patch: Patch for 2.7 branch
  • python-3.3-test_warnings.py_use_assert_python_ok.patch: Patch for 3.3 branch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/pitrou'
closed_at = <Date 2014-01-29.22:45:36.768>
created_at = <Date 2014-01-24.02:49:19.209>
labels = ['type-feature', 'tests']
title = 'Use test.script_helper.assert_python_ok() instead of subprocess.* in test.test_warnings'
updated_at = <Date 2014-01-29.22:45:36.767>
user = 'https://bugs.python.org/Arfrever'

    bugs.python.org fields:

    activity = <Date 2014-01-29.22:45:36.767>
actor = 'pitrou'
assignee = 'pitrou'
closed = True
closed_date = <Date 2014-01-29.22:45:36.768>
closer = 'pitrou'
components = ['Tests']
creation = <Date 2014-01-24.02:49:19.209>
creator = 'Arfrever'
dependencies = []
files = ['33671', '33672']
hgrepos = []
issue_num = 20373
keywords = ['patch']
message_count = 4.0
messages = ['209030', '209688', '209689', '209690']
nosy_count = 3.0
nosy_names = ['pitrou', 'Arfrever', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20373'
versions = ['Python 3.3', 'Python 3.4']
    @Arfrever
    Copy link
    Mannequin Author

    Arfrever mannequin commented Jan 24, 2014

    These patches make test.test_warnings use test.script_helper.assert_python_ok() instead of subprocess.*, as suggested by Antoine in msg209022.

    @Arfrever Arfrever mannequin assigned pitrou Jan 24, 2014
    @Arfrever Arfrever mannequin added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Jan 24, 2014
    @pitrou
    Copy link
    Member

    pitrou commented Jan 29, 2014

    There's not much point in changing the 2.7 tests at this point. It's reasonable to change both 3.3 and 3.x, so as to avoid divergence.

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Jan 29, 2014

    New changeset d844b31471b5 by Antoine Pitrou in branch '3.3':
    Issue bpo-20373: generalize use of test.script_helper in test_warnings. Patch by Arfrever.
    http://hg.python.org/cpython/rev/d844b31471b5

    New changeset 04b658b3fe7c by Antoine Pitrou in branch 'default':
    Issue bpo-20373: generalize use of test.script_helper in test_warnings. Patch by Arfrever.
    http://hg.python.org/cpython/rev/04b658b3fe7c

    @pitrou
    Copy link
    Member

    pitrou commented Jan 29, 2014

    Thanks for the patch!

    @pitrou pitrou closed this as completed Jan 29, 2014
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @pitrou pitrou

    Labels
    tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @pitrou