A kqueue's test doesn't pass on OpenBSD 4.6-beta, 4.4, & 4.5:

FAILED (failures=1)
Traceback (most recent call last):
  File "Lib/test/test_kqueue.py", line 186, in <module>
    test_main()
  File "Lib/test/test_kqueue.py", line 183, in test_main
    support.run_unittest(TestKQueue)
  File "/home/henry/py3k/Lib/test/support.py", line 882, in run_unittest
    _run_suite(suite)
  File "/home/henry/py3k/Lib/test/support.py", line 865, in _run_suite
    raise TestFailed(err)
test.support.TestFailed: Traceback (most recent call last):
  File "Lib/test/test_kqueue.py", line 119, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(6, -2, 5), (7, -2, 5)] != [(6, -2, 0),
(7, -2, 0)]

First differing element 0:
(6, -2, 5)
(6, -2, 0)

- [(6, -2, 5), (7, -2, 5)]
?          ^           ^

+ [(6, -2, 0), (7, -2, 0)]
?          ^           ^

It looks like OpenBSD behaves like Darwin. The attached patch fixes the
test.

The same patch was applied to the Python port by OpenBSD developer Damien Miller:

http://www.openbsd.org/cgi-bin/cvsweb/ports/lang/python/2.6/patches/patch-Lib_test_test_kqueue_py


Mark, would it be ok in this situation to apply the patch even though
personally I don't know if OpenBSD kqueue behaves like Darwin kqueue?

Yes, please do apply the patch!

Mark, thanks. - The patch is good on OpenBSD-4.5-i386-Celeron,
but I get additional failures on OpenBSD-4.7-beta-amd64-QEMU.

This could be the result of running a beta under qemu.

Henry, could you confirm if the patch works on amd64/OpenBSD-4.7-stable?



======================================================================
FAIL: test_create_event (test.test_kqueue.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stefan/svn/py3k/Lib/test/test_kqueue.py", line 29, in test_create_event
    self.assertEqual(ev.ident, fd)
AssertionError: 562945658454018 != 2

======================================================================
FAIL: test_queue_event (test.test_kqueue.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/stefan/svn/py3k/Lib/test/test_kqueue.py", line 130, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(1688841270329350, -2, 5), (1... != [(6, -2, 0), (7, -2, 0)]

First differing element 0:
(1688841270329350, -2, 5)
(6, -2, 0)

- [(1688841270329350, -2, 5), (1688841270329351, -2, 5)]
+ [(6, -2, 0), (7, -2, 0)]

The patch works well with on amd64/OpenBSD-current (CVS from May 14 or
15).

I don't have access to a 4.7-stable right now.

On Fri, May 14, 2010 at 05:58:10PM +0000, Stefan Krah wrote:
> 
> Stefan Krah <stefan-usenet@bytereef.org> added the comment:
> 
> Mark, thanks. - The patch is good on OpenBSD-4.5-i386-Celeron,
> but I get additional failures on OpenBSD-4.7-beta-amd64-QEMU.
> 
> This could be the result of running a beta under qemu.
> 
> Henry, could you confirm if the patch works on amd64/OpenBSD-4.7-stable?
> 
> 
> 
> ======================================================================
> FAIL: test_create_event (test.test_kqueue.TestKQueue)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/stefan/svn/py3k/Lib/test/test_kqueue.py", line 29, in test_create_event
>     self.assertEqual(ev.ident, fd)
> AssertionError: 562945658454018 != 2
> 
> ======================================================================
> FAIL: test_queue_event (test.test_kqueue.TestKQueue)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/home/stefan/svn/py3k/Lib/test/test_kqueue.py", line 130, in test_queue_event
>     (server.fileno(), select.KQ_FILTER_WRITE, flags)])
> AssertionError: Lists differ: [(1688841270329350, -2, 5), (1... != [(6, -2, 0), (7, -2, 0)]
> 
> First differing element 0:
> (1688841270329350, -2, 5)
> (6, -2, 0)
> 
> - [(1688841270329350, -2, 5), (1688841270329351, -2, 5)]
> + [(6, -2, 0), (7, -2, 0)]
> 
> ----------
> 
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue6419>
> _______________________________________

Stephan, did you apply the patch?

I think the failures you were experiencing on amd64 could be due to issue #12181: OpenBSD's struct kevent definition differs from FreeBSD/NetBSD, which can trigger a segfault on sparc64 (which doesn't allow unaligned access).

By the way, Henry, would you be interested in writting a patch for issue #12181?

No, I didn't commit it. Currently I don't have an amd64 OpenBSD install to do further testing.

The problem could be #12181, it could also be qemu, which sometimes has
issues with OpenBSD.

Rémi, can you reproduce this problem?
Could you test the patch attached?
(It's maybe already part of OPenBSD's tree, in which case it would certainly be nice to include it).

Hi,
I think this issue is relied to issue 12181.

I have made tests.

################
1)with no patch:
################
testPair (__main__.TestKQueue) ... ok
test_create_event (__main__.TestKQueue) ... FAIL
test_create_queue (__main__.TestKQueue) ... ok
test_queue_event (__main__.TestKQueue) ... FAIL

======================================================================
FAIL: test_create_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 28, in test_create_event
    self.assertEqual(ev.ident, fd)
AssertionError: 562945658454018L != 2

======================================================================
FAIL: test_queue_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 129, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(1688841270329350L, -2, 5L), ... != [(6, -2, 0), (7, -2, 0)]

First differing element 0:
(1688841270329350L, -2, 5L)
(6, -2, 0)

- [(1688841270329350L, -2, 5L), (1688841270329351L, -2, 5L)]
+ [(6, -2, 0), (7, -2, 0)]

----------------------------------------------------------------------
Ran 4 tests in 0.002s

FAILED (failures=2)
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 196, in <module>
    test_main()
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 193, in test_main
    test_support.run_unittest(TestKQueue)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1087, in run_unittest
    _run_suite(suite)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1070, in _run_suite
    raise TestFailed(err)
test.test_support.TestFailed: multiple errors occurred

#####################################
2)with patch-Lib_test_test_kqueue_py:
#####################################
testPair (__main__.TestKQueue) ... ok
test_create_event (__main__.TestKQueue) ... FAIL
test_create_queue (__main__.TestKQueue) ... ok
test_queue_event (__main__.TestKQueue) ... FAIL

======================================================================
FAIL: test_create_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 28, in test_create_event
    self.assertEqual(ev.ident, fd)
AssertionError: 562945658454018L != 2

======================================================================
FAIL: test_queue_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 130, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(1688841270329350L, -2, 5L), ... != [(6, -2, 5), (7, -2, 5)]

First differing element 0:
(1688841270329350L, -2, 5L)
(6, -2, 5)

- [(1688841270329350L, -2, 5L), (1688841270329351L, -2, 5L)]
+ [(6, -2, 5), (7, -2, 5)]

----------------------------------------------------------------------
Ran 4 tests in 0.002s

FAILED (failures=2)
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 197, in <module>
    test_main()
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 194, in test_main
    test_support.run_unittest(TestKQueue)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1087, in run_unittest
    _run_suite(suite)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1070, in _run_suite
    raise TestFailed(err)
test.test_support.TestFailed: multiple errors occurred

#####################################################
3)with patch-Modules_selectmodule_c (see issue 12181)
#####################################################
testPair (__main__.TestKQueue) ... ok
test_create_event (__main__.TestKQueue) ... ERROR
test_create_queue (__main__.TestKQueue) ... ok
test_queue_event (__main__.TestKQueue) ... FAIL

======================================================================
ERROR: test_create_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 74, in test_create_event
    ev = select.kevent(bignum, 1, 2, 3, sys.maxsize, bignum)
OverflowError: signed integer is greater than maximum

======================================================================
FAIL: test_queue_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 129, in test_queue_event
    (server.fileno(), select.KQ_FILTER_WRITE, flags)])
AssertionError: Lists differ: [(6L, -2, 5L), (7L, -2, 5L)] != [(6, -2, 0), (7, -2, 0)]

First differing element 0:
(6L, -2, 5L)
(6, -2, 0)

- [(6L, -2, 5L), (7L, -2, 5L)]
?    -      ^^     -      ^^

+ [(6, -2, 0), (7, -2, 0)]
?          ^           ^


----------------------------------------------------------------------
Ran 4 tests in 0.002s

FAILED (failures=1, errors=1)
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 196, in <module>
    test_main()
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 193, in test_main
    test_support.run_unittest(TestKQueue)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1087, in run_unittest
    _run_suite(suite)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1070, in _run_suite
    raise TestFailed(err)
test.test_support.TestFailed: multiple errors occurred

#####################################################################
4)with patch-Modules_selectmodule_c and patch-Lib_test_test_kqueue_py
#####################################################################
BRARY_PATH=/usr/ports/pobj/Python-2.7.1/Python-2.7.1 /usr/ports/pobj/Python-2.7.1/Python-2.7.1/python /usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py
testPair (__main__.TestKQueue) ... ok
test_create_event (__main__.TestKQueue) ... ERROR
test_create_queue (__main__.TestKQueue) ... ok
test_queue_event (__main__.TestKQueue) ... ok

======================================================================
ERROR: test_create_event (__main__.TestKQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 74, in test_create_event
    ev = select.kevent(bignum, 1, 2, 3, sys.maxsize, bignum)
OverflowError: signed integer is greater than maximum

----------------------------------------------------------------------
Ran 4 tests in 0.001s

FAILED (errors=1)
Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 197, in <module>
    test_main()
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 194, in test_main
    test_support.run_unittest(TestKQueue)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1087, in run_unittest
    _run_suite(suite)
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_support.py", line 1070, in _run_suite
    raise TestFailed(err)
test.test_support.TestFailed: Traceback (most recent call last):
  File "/usr/ports/pobj/Python-2.7.1/Python-2.7.1/Lib/test/test_kqueue.py", line 74, in test_create_event
    ev = select.kevent(bignum, 1, 2, 3, sys.maxsize, bignum)
OverflowError: signed integer is greater than maximum


Don't hesitate if you need more informations, but I think we must close issue 12181 before.

Thanks a lot,
Remi.

The test assumes that the input flags (EV_ADD, EV_ENABLE...) will be returned in the output events. It's apparently not the case on OpenBSD and NetBSD (and probably on OS-X neither, because this check is disabled on this platform), and I can't see anything in the kqueue man pages hinting to this behavior (only specific flags will be set on output, like EV_ERROR). Knowing which flag was specified is not really useful actually.

The patch attached just removes this check (we keep checking the file descriptors and filter, of course).

New changeset cfd4cd15809e by Charles-Francois Natali in branch '2.7':
Issue #6419: Fix a test_kqueue failure on some BSD flavors.
http://hg.python.org/cpython/rev/cfd4cd15809e

New changeset 96776fc3cbcc by Charles-Francois Natali in branch '3.3':
Issue #6419: Fix a test_kqueue failure on some BSD flavors.
http://hg.python.org/cpython/rev/96776fc3cbcc

New changeset 0c9415ddf403 by Charles-Francois Natali in branch 'default':
Issue #6419: Fix a test_kqueue failure on some BSD flavors.
http://hg.python.org/cpython/rev/0c9415ddf403

test_kqueue now passes on NetBSD (can't tell for OpenBSD, all buildbots are offline).

I'm closing this, feel free to repon in case of problem.