This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Docstring of combinations_with_replacement for consistency
Type: Stage: resolved
Components: Argument Clinic Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: rhettinger Nosy List: LeeDongGeon1996, corona10, larry, rhettinger
Priority: normal Keywords: patch

Created on 2022-02-12 09:13 by LeeDongGeon1996, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31293 merged LeeDongGeon1996, 2022-02-12 09:25
PR 31350 merged LeeDongGeon1996, 2022-02-15 09:21
PR 31356 merged LeeDongGeon1996, 2022-02-15 10:21
Messages (7)
msg413120 - (view) Author: DongGeon Lee (LeeDongGeon1996) * Date: 2022-02-12 09:13
I've found that there is an unnecessary double quote. It lost its another pair. It needs to be removed.

And I would like to suggest changing its output format in docstring for consistency with similar kinds of other methods, if it was not intentional.
msg413273 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-02-15 00:02
New changeset 278fdd3e3a2492665b2c2888fd2f428f7f59a3f5 by DongGeon Lee in branch 'main':
bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293)
https://github.com/python/cpython/commit/278fdd3e3a2492665b2c2888fd2f428f7f59a3f5
msg413281 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-02-15 10:06
@LeeDongGeon1996

Please send the backported patch to 3.9 also
msg413282 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-02-15 10:24
New changeset ac55cea3cbee4d40cf7320bd691f5327cff30f13 by DongGeon Lee in branch '3.10':
[3.10] bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293) (GH-31350)
https://github.com/python/cpython/commit/ac55cea3cbee4d40cf7320bd691f5327cff30f13
msg413286 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-02-15 12:22
New changeset ad47db34be23c5cd75ed5d5c220d4b56a9b5683c by DongGeon Lee in branch '3.9':
[3.9] bpo-46728: fix docstring of combinations_with_replacement for consistency (GH-31293). (GH-31356)
https://github.com/python/cpython/commit/ad47db34be23c5cd75ed5d5c220d4b56a9b5683c
msg413287 - (view) Author: Dong-hee Na (corona10) * (Python committer) Date: 2022-02-15 12:22
Thank you DongGeon :)
msg413290 - (view) Author: DongGeon Lee (LeeDongGeon1996) * Date: 2022-02-15 13:43
My pleasure :)
History
Date User Action Args
2022-04-11 14:59:56adminsetgithub: 90884
2022-02-15 13:43:30LeeDongGeon1996setmessages: + msg413290
2022-02-15 12:22:32corona10setstatus: open -> closed
resolution: fixed
messages: + msg413287

stage: patch review -> resolved
2022-02-15 12:22:13corona10setmessages: + msg413286
2022-02-15 10:24:12corona10setmessages: + msg413282
2022-02-15 10:21:26LeeDongGeon1996setpull_requests: + pull_request29506
2022-02-15 10:06:32corona10setmessages: + msg413281
2022-02-15 10:06:05corona10setversions: - Python 3.7, Python 3.8
2022-02-15 09:21:27LeeDongGeon1996setpull_requests: + pull_request29499
2022-02-15 00:02:29corona10setnosy: + corona10
messages: + msg413273
2022-02-12 10:59:52rhettingersetassignee: rhettinger

nosy: + rhettinger
2022-02-12 09:25:24LeeDongGeon1996setkeywords: + patch
stage: patch review
pull_requests: + pull_request29452
2022-02-12 09:13:23LeeDongGeon1996create