This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_peg_generator is extremely slow
Type: Stage: commit review
Components: Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: gregory.p.smith Nosy List: gregory.p.smith, jkloth, miss-islington, xtreak
Priority: normal Keywords: patch

Created on 2022-01-29 20:31 by gregory.p.smith, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 31015 merged gregory.p.smith, 2022-01-29 20:40
PR 31089 merged gregory.p.smith, 2022-02-02 20:22
PR 31093 merged miss-islington, 2022-02-03 04:03
PR 32338 merged jkloth, 2022-04-05 18:26
PR 32382 open jkloth, 2022-04-06 22:22
Messages (8)
msg412104 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-01-29 20:31
test_peg_generator is an extremely slow test.  This bug tracks any changes to reduce its runtime and test latency.
msg412125 - (view) Author: Karthikeyan Singaravelan (xtreak) * (Python committer) Date: 2022-01-30 04:48
See also issue46524 for a similar discussion.
msg412396 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-02 20:15
New changeset 164a017e13ee96bd1ea1ae79f5ac9e25fe83994e by Gregory P. Smith in branch 'main':
bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (#31015)
https://github.com/python/cpython/commit/164a017e13ee96bd1ea1ae79f5ac9e25fe83994e
msg412416 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-03 04:03
New changeset f5ebec4d3e1199ec38b88920cfde8e460e5120dd by Gregory P. Smith in branch '3.10':
[3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089)
https://github.com/python/cpython/commit/f5ebec4d3e1199ec38b88920cfde8e460e5120dd
msg412418 - (view) Author: miss-islington (miss-islington) Date: 2022-02-03 04:33
New changeset e8258608c28c65680253d0ca6167430e34c2fd87 by Miss Islington (bot) in branch '3.9':
[3.9] [3.10] bpo-46576: bpo-46524: Disable compiler optimization within test_peg_generator. (GH-31015) (GH-31089) (GH-31093)
https://github.com/python/cpython/commit/e8258608c28c65680253d0ca6167430e34c2fd87
msg412424 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-02-03 08:25
for my purposes those PRs make it reasonable, even though it remains one of our slowest tests.  we can reopen/reuse this issue for any further test_peg_generator performance improvements as needed.
msg416797 - (view) Author: Jeremy Kloth (jkloth) * Date: 2022-04-05 18:28
My PR-32338 further reduces the runtime of the test another ~25%.

On my machine, before 85s, after 65s.
msg416902 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2022-04-06 21:56
New changeset 612e422c6ea9df60d3382ed1491d8254c283e93f by Jeremy Kloth in branch 'main':
bpo-46576: Speed up test_peg_generator by using a static library for shared sources (GH-32338)
https://github.com/python/cpython/commit/612e422c6ea9df60d3382ed1491d8254c283e93f
History
Date User Action Args
2022-04-11 14:59:55adminsetgithub: 90734
2022-04-06 22:22:07jklothsetpull_requests: + pull_request30420
2022-04-06 21:56:11gregory.p.smithsetmessages: + msg416902
2022-04-05 18:28:06jklothsetmessages: + msg416797
2022-04-05 18:26:10jklothsetnosy: + jkloth

pull_requests: + pull_request30394
2022-02-03 08:25:22gregory.p.smithsetstatus: open -> closed
versions: + Python 3.9, Python 3.10
messages: + msg412424

assignee: gregory.p.smith
resolution: fixed
stage: patch review -> commit review
2022-02-03 04:33:03miss-islingtonsetmessages: + msg412418
2022-02-03 04:03:11miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request29278
2022-02-03 04:03:08gregory.p.smithsetmessages: + msg412416
2022-02-02 20:22:30gregory.p.smithsetpull_requests: + pull_request29273
2022-02-02 20:15:25gregory.p.smithsetmessages: + msg412396
2022-01-30 04:48:46xtreaksetnosy: + xtreak
messages: + msg412125
2022-01-29 20:40:21gregory.p.smithsetkeywords: + patch
stage: patch review
pull_requests: + pull_request29194
2022-01-29 20:31:42gregory.p.smithcreate