This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: C API documentation of Py_UNICODE_* character properties macros use Py_UNICODE instead of Py_UCS4
Type: Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9, Python 3.8, Python 3.7, Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: benjamin.peterson, docs@python, juliangilbey, miss-islington
Priority: normal Keywords: patch

Created on 2022-01-04 07:14 by juliangilbey, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 30387 merged juliangilbey, 2022-01-04 07:32
PR 30533 merged miss-islington, 2022-01-11 14:33
PR 30534 merged miss-islington, 2022-01-11 14:33
Messages (4)
msg409649 - (view) Author: Julian Gilbey (juliangilbey) * Date: 2022-01-04 07:14
The documentation at https://docs.python.org/3/c-api/unicode.html?highlight=isalpha#unicode-character-properties lists a series of macros such as Py_UNICODE_ISSPACE(Py_UNICODE ch).  However, the input type for these macros was changed from Py_UNICODE to Py_UCS4 in commit 324ac65cebf4b0141b946452a2604715f1ca7010 on Wed Aug 18 20:44:58 2010 +0000, but it seems that the documentation has never been updated.  The fix should be easy; I'll make a PR for it.
msg410302 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2022-01-11 14:33
New changeset 43c5c1369cb21f08a1dc1d63923c3586b883e3e8 by Julian Gilbey in branch 'main':
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code (GH-30387)
https://github.com/python/cpython/commit/43c5c1369cb21f08a1dc1d63923c3586b883e3e8
msg410303 - (view) Author: miss-islington (miss-islington) Date: 2022-01-11 14:53
New changeset 4cfb10979d74b8513ec751b81454709f38e3b51a by Miss Islington (bot) in branch '3.10':
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code (GH-30387)
https://github.com/python/cpython/commit/4cfb10979d74b8513ec751b81454709f38e3b51a
msg410304 - (view) Author: miss-islington (miss-islington) Date: 2022-01-11 14:59
New changeset 238a36b753affd373a315b81a5024aed7ebf6479 by Miss Islington (bot) in branch '3.9':
closes bpo-46253: Change Py_UNICODE to Py_UCS4 in the C API docs to match the current source code (GH-30387)
https://github.com/python/cpython/commit/238a36b753affd373a315b81a5024aed7ebf6479
History
Date User Action Args
2022-04-11 14:59:54adminsetgithub: 90411
2022-01-11 14:59:37miss-islingtonsetmessages: + msg410304
2022-01-11 14:53:29miss-islingtonsetmessages: + msg410303
2022-01-11 14:33:23miss-islingtonsetpull_requests: + pull_request28735
2022-01-11 14:33:19miss-islingtonsetnosy: + miss-islington

pull_requests: + pull_request28734
2022-01-11 14:33:17benjamin.petersonsetstatus: open -> closed

nosy: + benjamin.peterson
messages: + msg410302

resolution: fixed
stage: patch review -> resolved
2022-01-04 07:32:46juliangilbeysetkeywords: + patch
stage: patch review
pull_requests: + pull_request28595
2022-01-04 07:14:07juliangilbeycreate