This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: OpenSSL 3.0 uses different version scheme
Type: behavior Stage: patch review
Components: SSL, Tests Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: christian.heimes, cstratak, hroncok, miss-islington, penguinolog
Priority: normal Keywords: patch

Created on 2021-12-17 10:51 by penguinolog, last changed 2022-04-11 14:59 by admin.

Pull Requests
URL Status Linked Edit
PR 30170 merged christian.heimes, 2021-12-17 13:52
PR 30172 merged miss-islington, 2021-12-17 15:17
PR 30173 merged christian.heimes, 2021-12-17 15:33
Messages (12)
msg408770 - (view) Author: Alexey Stepanov (penguinolog) Date: 2021-12-17 10:51
Documentation: https://www.openssl.org/docs/manmaster/man3/OpenSSL_version_num.html

Python build fail with OpenSSL 3.0.1
(looks like OpenSSL broken deprecated API)
msg408773 - (view) Author: Alexey Stepanov (penguinolog) Date: 2021-12-17 11:17
Error example:
test_ssl: testing with 'OpenSSL 3.0.1 14 Dec 2021' (3, 0, 0, 1, 0)
...
AssertionError: False is not true : ('OpenSSL 3.0.1 14 Dec 2021', (3, 0, 0, 1, 0), '0x30000010')
msg408776 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-17 13:35
The test case does not work for OpenSSL >= 3.0.1. The test assumes that the version starts with M.NN.FF, but OpenSSL 3 uses M.NN.PP. The FF (fix) part is always 00. The issue didn't show up before because fix and patch level were 0 for 3.0.0 alphas and betas.
msg408779 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-17 14:15
FYI, OpenSSL_version_num() is not deprecated and Python does not fail to build with OpenSSL 3.0.1. One test case is failing because OpenSSL 3 changed the version scheme slightly.
msg408788 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-17 15:17
New changeset 2985feac4e02d590bb78bcce9e30864be53280ac by Christian Heimes in branch 'main':
bpo-46114: Fix OpenSSL version check for 3.0.1 (GH-30170)
https://github.com/python/cpython/commit/2985feac4e02d590bb78bcce9e30864be53280ac
msg408792 - (view) Author: miss-islington (miss-islington) Date: 2021-12-17 15:38
New changeset 251d2eadc7f5b4042245709f41c38169a284e146 by Miss Islington (bot) in branch '3.10':
bpo-46114: Fix OpenSSL version check for 3.0.1 (GH-30170)
https://github.com/python/cpython/commit/251d2eadc7f5b4042245709f41c38169a284e146
msg408795 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-12-17 16:02
New changeset a9b3edb66f2976a5895b6399ee905ac2f27718ac by Christian Heimes in branch '3.9':
[3.9] bpo-46114: Fix OpenSSL version check for 3.0.1 (GH-30170) (GH-30173)
https://github.com/python/cpython/commit/a9b3edb66f2976a5895b6399ee905ac2f27718ac
msg415499 - (view) Author: Miro Hrončok (hroncok) * Date: 2022-03-18 14:07
3.8 is security only, so I suppose there is no chance of getting the test fixed as well?
msg415502 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2022-03-18 15:05
Correct, I didn't backport this fix and several other OpenSSL 3.0 related fixes to Python 3.8 because 3.8 is in security-only mode.
msg415504 - (view) Author: Miro Hrončok (hroncok) * Date: 2022-03-18 15:11
Ack, will do it downstream-only.
msg415517 - (view) Author: Charalampos Stratakis (cstratak) * Date: 2022-03-18 18:22
3.8 builds are still running on the buildbots so not fixing 3.8 will cause them to fail.
msg415839 - (view) Author: Charalampos Stratakis (cstratak) * Date: 2022-03-22 23:20
Case in point: https://buildbot.python.org/all/#/builders/355/builds/338
History
Date User Action Args
2022-04-11 14:59:53adminsetgithub: 90272
2022-03-22 23:20:19cstrataksetmessages: + msg415839
2022-03-18 18:22:22cstrataksetnosy: + cstratak
messages: + msg415517
2022-03-18 15:11:51hroncoksetmessages: + msg415504
2022-03-18 15:05:18christian.heimessetmessages: + msg415502
2022-03-18 14:07:58hroncoksetnosy: + hroncok
messages: + msg415499
2021-12-17 16:02:41christian.heimessetmessages: + msg408795
2021-12-17 15:38:18miss-islingtonsetmessages: + msg408792
2021-12-17 15:33:34christian.heimessetpull_requests: + pull_request28389
2021-12-17 15:17:42miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request28388
2021-12-17 15:17:39christian.heimessetmessages: + msg408788
2021-12-17 14:15:27christian.heimessetmessages: + msg408779
title: OpenSSL deprecated OpenSSL_version_num() since version 3.0.0 -> OpenSSL 3.0 uses different version scheme
2021-12-17 13:52:25christian.heimessetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request28387
2021-12-17 13:37:11christian.heimessetassignee: christian.heimes ->
stage: needs patch
type: behavior
components: + Tests
versions: - Python 3.8
2021-12-17 13:35:58christian.heimessetmessages: + msg408776
2021-12-17 11:17:38penguinologsetmessages: + msg408773
2021-12-17 10:51:19penguinologcreate