➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-11-29 19:43 by dfederm, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 29854 | merged | dfederm, 2021-11-29 19:49 | |
| PR 29855 | merged | miss-islington, 2021-11-29 22:40 | |
| PR 29856 | merged | miss-islington, 2021-11-29 22:40 | |
| Messages (6) | |||
|---|---|---|---|
| msg407320 - (view) | Author: David Federman (dfederm) * | Date: 2021-11-29 19:43 | |
When building with Visual Studio 2017+, any Directory.Build.props/targets above the repo in the file structure (eg. in the parent repo when the python repo is a submodule) will be imported automatically. |
|||
| msg407325 - (view) | Author: Steve Dower (steve.dower) *  |
Date: 2021-11-29 21:17 | |
Nice catch, thanks! Did you start the CLA process already? (I personally would exempt this PR from it as "not sufficiently creative", but I'm not sure I'm allowed to do that anymore...) |
|||
| msg407331 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-11-29 22:40 | |
New changeset 734ed3538314c9651ae64d5e2e0e98aae3aec17b by David Federman in branch 'main': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) https://github.com/python/cpython/commit/734ed3538314c9651ae64d5e2e0e98aae3aec17b |
|||
| msg407332 - (view) | Author: Steve Dower (steve.dower) * |
Date: 2021-11-29 23:06 | |
Looks like it's gone through. Thanks! |
|||
| msg407333 - (view) | Author: miss-islington (miss-islington) | Date: 2021-11-29 23:08 | |
New changeset 5a6d9ed700ecc6984387e0533b11d81692c40469 by Miss Islington (bot) in branch '3.10': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) https://github.com/python/cpython/commit/5a6d9ed700ecc6984387e0533b11d81692c40469 |
|||
| msg407334 - (view) | Author: miss-islington (miss-islington) | Date: 2021-11-29 23:08 | |
New changeset b91805ec0283f0642aa3311ec617c8596f65b7b4 by Miss Islington (bot) in branch '3.9': bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) https://github.com/python/cpython/commit/b91805ec0283f0642aa3311ec617c8596f65b7b4 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:52 | admin | set | github: 90089 |
| 2021-11-29 23:08:57 | miss-islington | set | messages: + msg407334 |
| 2021-11-29 23:08:41 | miss-islington | set | nosy:
+ miss-islington messages: + msg407333 |
| 2021-11-29 23:06:25 | steve.dower | set | status: open -> closed versions: + Python 3.9, Python 3.10 nosy: - miss-islington messages: + msg407332 resolution: fixed stage: patch review -> resolved |
| 2021-11-29 22:40:47 | miss-islington | set | pull_requests: + pull_request28084 |
| 2021-11-29 22:40:42 | steve.dower | set | messages: + msg407331 |
| 2021-11-29 22:40:42 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request28083 |
| 2021-11-29 21:17:04 | steve.dower | set | messages: + msg407325 |
| 2021-11-29 20:17:18 | eric.smith | set | nosy:
+ paul.moore, tim.golden, zach.ware, steve.dower components: + Windows |
| 2021-11-29 19:49:21 | dfederm | set | keywords:
+ patch stage: patch review pull_requests: + pull_request28082 |
| 2021-11-29 19:43:33 | dfederm | create | |