This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Replace PyImport_ImportModuleNoBlock with PyImport_ImportModule in std modules
Type: enhancement Stage: resolved
Components: C API Versions: Python 3.11
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: asvetlov, georg.brandl, kumaraditya
Priority: low Keywords: patch

Created on 2021-11-20 16:27 by georg.brandl, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29665 merged georg.brandl, 2021-11-20 16:33
PR 30046 merged kumaraditya, 2021-12-11 08:38
Messages (5)
msg406671 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2021-11-20 16:27
PyImport_ImportModuleNoBlock is the same as PyImport_ImportModule since 3.3, according to the docs.

PyCapsule_Import has a no_block parameter to choose, is still documented as if it is relevant, and the implementation also still uses it.
msg406672 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2021-11-20 16:29
PR is underway.
msg408010 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2021-12-08 11:18
The main branch has a dozen PyImport_ImportModuleNoBlock() usages.

Would you replace them also?
msg408369 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2021-12-12 08:45
New changeset 41026c3155012d6ea50e01205c163b6739c675b8 by Kumar Aditya in branch 'main':
bpo-45855: Replaced deprecated `PyImport_ImportModuleNoBlock` with PyImport_ImportModule (GH-30046)
https://github.com/python/cpython/commit/41026c3155012d6ea50e01205c163b6739c675b8
msg408371 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2021-12-12 09:49
New changeset f4095e53ab708d95e019c909d5928502775ba68f by Georg Brandl in branch 'main':
bpo-45855: document that `no_block` has no use anymore in PyCapsule_Import (#29665)
https://github.com/python/cpython/commit/f4095e53ab708d95e019c909d5928502775ba68f
History
Date User Action Args
2022-04-11 14:59:52adminsetgithub: 90013
2021-12-12 09:50:44georg.brandlsetstatus: open -> closed
2021-12-12 09:49:56georg.brandlsetmessages: + msg408371
2021-12-12 09:09:43georg.brandlsetstatus: closed -> open
2021-12-12 08:47:07asvetlovsetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
title: PyCapsule_Import still using PyImport_ImportModuleNoBlock -> Replace PyImport_ImportModuleNoBlock with PyImport_ImportModule in std modules
2021-12-12 08:45:28asvetlovsetmessages: + msg408369
2021-12-11 08:38:24kumaradityasetnosy: + kumaraditya
pull_requests: + pull_request28271
2021-12-08 11:18:30asvetlovsetnosy: + asvetlov

messages: + msg408010
versions: + Python 3.11, - Python 3.10
2021-11-20 16:33:14georg.brandlsetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request27907
2021-11-20 16:29:28georg.brandlsetmessages: + msg406672
2021-11-20 16:27:18georg.brandlcreate