This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Move expat handling into configure and Makefile
Type: enhancement Stage: resolved
Components: Build Versions: Python 3.11
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: christian.heimes Nosy List: christian.heimes
Priority: normal Keywords: patch

Created on 2021-11-13 15:37 by christian.heimes, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 29547 merged christian.heimes, 2021-11-13 15:44
Messages (3)
msg406281 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-11-13 15:37
Move logic for --with-system-expat out of into configure and Makefile. This will enable --with-system-expat in Modules/Setup without manual patching.

* Set CFLAGS and LDFLAGS for pyexpat and libexpat in configure.
* Build a static libexpat.a from our copy of expat when --with-system-expat is not given
* Either link pyexpat with libexpat.a or system libexpat.

Basically use the same approach as decimal changeset bpo-45798.
msg406282 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-11-13 15:44
An intermediate libexpat.a simplifies Modules/Setup.

The explicit rules are required to support BSD make. bmake does neither have "%.o: %.c" nor target variable overrides like GNU make.
msg406312 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2021-11-14 09:02
New changeset 464e6616be86129e33af6d9e43540c260d6804d5 by Christian Heimes in branch 'main':
bpo-45800: Move pyexpat build setup into configure (GH-29547)
Date User Action Args
2022-04-11 14:59:52adminsetgithub: 89958
2021-11-14 09:02:40christian.heimessetmessages: + msg406312
2021-11-14 09:02:39christian.heimessetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-11-13 15:44:43christian.heimessetkeywords: + patch
stage: patch review
pull_requests: + pull_request27796
2021-11-13 15:44:00christian.heimessetmessages: + msg406282
2021-11-13 15:37:55christian.heimescreate