➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-10-22 13:21 by christian.heimes, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 29161 | merged | christian.heimes, 2021-10-22 13:30 | |
| PR 29168 | merged | miss-islington, 2021-10-22 18:03 | |
| PR 29169 | merged | miss-islington, 2021-10-22 18:03 | |
| Messages (4) | |||
|---|---|---|---|
| msg404766 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2021-10-22 13:21 | |
I think that makesetup uses the wrong CFLAGS variable for shared modules. The script uses PY_CFLAGS:
no) cc="$cc \$(CCSHARED) \$(PY_CFLAGS) \$(PY_CPPFLAGS)";;
while setup.py uses PY_CFLAGS_NODIST:
set_compiler_flags('CFLAGS', 'PY_CFLAGS_NODIST')
The flags are similar but not equal. Amongst others PY_CFLAGS does not include Include/internal while PY_CFLAGS_NODIST has -I./Include/internal.
|
|||
| msg404804 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2021-10-22 18:03 | |
New changeset f6e8b80d20159596cf641305bad3a833bedd2f4f by Christian Heimes in branch 'main': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f |
|||
| msg404807 - (view) | Author: miss-islington (miss-islington) | Date: 2021-10-22 18:22 | |
New changeset 19903085c3ad7a17c8047e1556c700f2eb109931 by Miss Islington (bot) in branch '3.10': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/19903085c3ad7a17c8047e1556c700f2eb109931 |
|||
| msg404810 - (view) | Author: miss-islington (miss-islington) | Date: 2021-10-22 18:30 | |
New changeset 269bf56e3d352c415ec38f93017ba8e291ddb18a by Miss Islington (bot) in branch '3.9': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/269bf56e3d352c415ec38f93017ba8e291ddb18a |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:51 | admin | set | github: 89734 |
| 2021-10-22 19:12:54 | christian.heimes | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-10-22 18:30:01 | miss-islington | set | messages: + msg404810 |
| 2021-10-22 18:22:20 | miss-islington | set | messages: + msg404807 |
| 2021-10-22 18:03:12 | miss-islington | set | pull_requests: + pull_request27442 |
| 2021-10-22 18:03:07 | christian.heimes | set | messages: + msg404804 |
| 2021-10-22 18:03:06 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request27441 |
| 2021-10-22 13:30:12 | christian.heimes | set | keywords:
+ patch stage: patch review pull_requests: + pull_request27436 |
| 2021-10-22 13:21:54 | christian.heimes | create | |