This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: pprint -> underscore_numbers argument not working
Type: Stage: resolved
Components: Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: eric.smith, jpvincent, miss-islington
Priority: normal Keywords: patch

Created on 2021-10-21 19:48 by jpvincent, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
image.png jpvincent, 2021-10-21 19:48
Pull Requests
URL Status Linked Edit
PR 29129 merged eric.smith, 2021-10-21 20:15
PR 29133 merged miss-islington, 2021-10-21 20:43
Messages (5)
msg404636 - (view) Author: Jean-Philippe VINCENT (jpvincent) Date: 2021-10-21 19:48
Hello,

I just tried the new attribute underscore_numbers with pprint, it doesn't work for me. I'm working on Windows.

[cid:8779885d-01bf-4162-9427-a44de152f7ac]

Best regards,

Jean-Philippe
msg404640 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2021-10-21 20:05
Please do not post screen shots. They don't work for people with vision impairments, and we can't copy and past from them, so it makes it harder for us to help you.

It looks like it works with pformat, and not pprint:

>>> pprint.pformat(10000, underscore_numbers=True)
'10_000'
>>> pprint.pprint(10000, underscore_numbers=True)
10000
msg404643 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2021-10-21 20:09
It's a bug in pprint.py. PR to follow shortly.
msg404651 - (view) Author: Eric V. Smith (eric.smith) * (Python committer) Date: 2021-10-21 20:43
New changeset 087f089e5e04d5b132ffbff0576667d591f13219 by Eric V. Smith in branch 'main':
bpo-45557: Fix underscore_numbers in pprint.pprint(). (GH-29129)
https://github.com/python/cpython/commit/087f089e5e04d5b132ffbff0576667d591f13219
msg404664 - (view) Author: miss-islington (miss-islington) Date: 2021-10-21 21:17
New changeset 6b75ad5fd47e5b34a04197927f748d0391898de7 by Miss Islington (bot) in branch '3.10':
bpo-45557: Fix underscore_numbers in pprint.pprint(). (GH-29129)
https://github.com/python/cpython/commit/6b75ad5fd47e5b34a04197927f748d0391898de7
History
Date User Action Args
2022-04-11 14:59:51adminsetgithub: 89720
2021-10-21 21:54:47eric.smithsetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: + Python 3.10, Python 3.11
2021-10-21 21:17:06miss-islingtonsetmessages: + msg404664
2021-10-21 20:43:04miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request27409
2021-10-21 20:43:04eric.smithsetmessages: + msg404651
2021-10-21 20:15:14eric.smithsetkeywords: + patch
stage: patch review
pull_requests: + pull_request27405
2021-10-21 20:09:08eric.smithsetmessages: + msg404643
2021-10-21 20:05:25eric.smithsetnosy: + eric.smith
messages: + msg404640
2021-10-21 19:52:27jpvincentsettitle: Issue 42914 -> pprint -> underscore_numbers argument not working
2021-10-21 19:48:33jpvincentcreate