➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-09-23 09:32 by sobolevn, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 28540 | merged | sobolevn, 2021-09-24 07:43 | |
| PR 28609 | merged | miss-islington, 2021-09-28 21:18 | |
| PR 28610 | merged | miss-islington, 2021-09-28 21:18 | |
| Messages (5) | |||
|---|---|---|---|
| msg402482 - (view) | Author: Nikita Sobolev (sobolevn) *  |
Date: 2021-09-23 09:32 | |
Looks like we never test error that `markers` are limited to `None` and `dict` types. Here: https://github.com/python/cpython/blob/main/Modules/_json.c#L1252-L1255 Coverage report: https://app.codecov.io/gh/python/cpython/blob/master/Modules/_json.c line: 1252 I will submit a unit test for it today. Related: https://bugs.python.org/issue6986 |
|||
| msg402808 - (view) | Author: Łukasz Langa (lukasz.langa) *  |
Date: 2021-09-28 21:18 | |
New changeset e046aabbe386fdf32bae6ffb7fae5ce479fd10c6 by Nikita Sobolev in branch 'main': bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540) https://github.com/python/cpython/commit/e046aabbe386fdf32bae6ffb7fae5ce479fd10c6 |
|||
| msg402810 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-09-28 21:52 | |
New changeset c6b5ceae3475d7782ed88f4e54bdb2232a8eb088 by Miss Islington (bot) in branch '3.9': bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540) (GH-28610) https://github.com/python/cpython/commit/c6b5ceae3475d7782ed88f4e54bdb2232a8eb088 |
|||
| msg402811 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-09-28 21:56 | |
New changeset 1cb17be3e6a4d94629606a613acd07f78d50348b by Miss Islington (bot) in branch '3.10': bpo-45269: test wrong `markers` type to `c_make_encoder` (GH-28540) (GH-28609) https://github.com/python/cpython/commit/1cb17be3e6a4d94629606a613acd07f78d50348b |
|||
| msg402812 - (view) | Author: Łukasz Langa (lukasz.langa) * |
Date: 2021-09-28 21:57 | |
Thanks, Nikita! ✨ 🍰 ✨ |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:50 | admin | set | github: 89432 |
| 2021-09-28 21:57:29 | lukasz.langa | set | status: open -> closed resolution: fixed messages: + msg402812 stage: patch review -> resolved |
| 2021-09-28 21:56:59 | lukasz.langa | set | messages: + msg402811 |
| 2021-09-28 21:52:09 | lukasz.langa | set | messages: + msg402810 |
| 2021-09-28 21:18:15 | miss-islington | set | pull_requests: + pull_request26981 |
| 2021-09-28 21:18:11 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request26980 |
| 2021-09-28 21:18:08 | lukasz.langa | set | nosy:
+ lukasz.langa messages: + msg402808 |
| 2021-09-24 07:43:34 | sobolevn | set | keywords:
+ patch stage: patch review pull_requests: + pull_request26924 |
| 2021-09-23 09:32:38 | sobolevn | create | |