This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: PyAiter_Check & PyObject_GetAiter issues
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, pablogsal, yselivanov
Priority: release blocker Keywords: patch

Created on 2021-09-07 04:50 by yselivanov, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28194 merged yselivanov, 2021-09-07 04:55
PR 28199 merged miss-islington, 2021-09-07 10:52
Messages (3)
msg401206 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2021-09-07 04:50
Per discussion on python-dev (also see the linked email), PyAiter_Check should only check for `__anext__` existence (and not for `__aiter__`) to be consistent with `Py_IterCheck`.

While there, I'd like to rename PyAiter_Check to PyAIter_Check and PyObject_GetAiter to PyObject_GetAIter (i -> I).  First, we should apply CamelCase convention correctly, here "async" and "iter" are separate words; second, "Aiter" is marked as invalid spelling by spell checkers in IDEs which is annoying.

See https://mail.python.org/archives/list/python-dev@python.org/message/BRHMOFPEKGQCCKEKEEKGSYDR6NOPMRCC/ for more details.
msg401232 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2021-09-07 10:52
New changeset 2c3474a637949aa6f2f7e15f9764c2dfc49cdba1 by Yury Selivanov in branch 'main':
bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194)
https://github.com/python/cpython/commit/2c3474a637949aa6f2f7e15f9764c2dfc49cdba1
msg401244 - (view) Author: Pablo Galindo Salgado (pablogsal) * (Python committer) Date: 2021-09-07 11:43
New changeset 53257cf19fc06fff446815b3278d4b80ec3e7ba3 by Miss Islington (bot) in branch '3.10':
bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) (GH-28199)
https://github.com/python/cpython/commit/53257cf19fc06fff446815b3278d4b80ec3e7ba3
History
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89286
2021-09-07 11:46:00pablogsalsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-09-07 11:43:36pablogsalsetmessages: + msg401244
2021-09-07 10:52:40miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26624
2021-09-07 10:52:40pablogsalsetmessages: + msg401232
2021-09-07 04:55:48yselivanovsetkeywords: + patch
pull_requests: + pull_request26618
2021-09-07 04:50:40yselivanovcreate