This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: use ADDOP_LOAD_CONST consistently
Type: Stage: resolved
Components: Interpreter Core Versions: Python 3.11, Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Mark.Shannon, gvanrossum, iritkatriel, miss-islington, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-08-28 17:46 by iritkatriel, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 28015 merged iritkatriel, 2021-08-28 17:48
PR 28100 merged miss-islington, 2021-08-31 17:42
Messages (3)
msg400485 - (view) Author: Irit Katriel (iritkatriel) * (Python committer) Date: 2021-08-28 17:46
The compiler generally uses ADDOP_LOAD_CONST to emit a LOAD_CONST, but there are two places that use ADDOP_O(c, LOAD_CONST, Py_None, consts);

This is currently equivalent to ADDOP_LOAD_CONST(c, Py_None);

It should be replaced because we may soon change ADDOP_LOAD_CONST.
msg400759 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2021-08-31 17:41
New changeset 70ccee418d1f9d34ed15cfe7104221f9cfd27d03 by Irit Katriel in branch 'main':
bpo-45039: Consistently use ADDOP_LOAD_CONST in compiler rather than ADDOP_O(c, LOAD_CONST,...) (GH-28015)
https://github.com/python/cpython/commit/70ccee418d1f9d34ed15cfe7104221f9cfd27d03
msg400765 - (view) Author: miss-islington (miss-islington) Date: 2021-08-31 18:08
New changeset ebbd0ac5d8850a1630090c210b2454b4b26c7daa by Miss Islington (bot) in branch '3.10':
bpo-45039: Consistently use ADDOP_LOAD_CONST in compiler rather than ADDOP_O(c, LOAD_CONST,...) (GH-28015)
https://github.com/python/cpython/commit/ebbd0ac5d8850a1630090c210b2454b4b26c7daa
History
Date User Action Args
2022-04-11 14:59:49adminsetgithub: 89202
2021-08-31 18:08:41miss-islingtonsetmessages: + msg400765
2021-08-31 17:47:18iritkatrielsetstatus: open -> closed
stage: patch review -> resolved
resolution: fixed
versions: + Python 3.10
2021-08-31 17:42:01miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request26543
2021-08-31 17:41:28serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg400759
2021-08-28 18:09:28iritkatrielsetnosy: + gvanrossum, Mark.Shannon
2021-08-28 17:48:52iritkatrielsetkeywords: + patch
stage: patch review
pull_requests: + pull_request26459
2021-08-28 17:46:22iritkatrielcreate