This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Windows buildbots hang after fatal exit
Type: Stage: resolved
Components: Tests, Windows Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jkloth, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2021-06-07 17:07 by jkloth, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 26578 merged jkloth, 2021-06-07 17:16
PR 32050 merged jkloth, 2022-03-22 14:31
PR 32048 merged jkloth, 2022-03-22 17:36
Messages (8)
msg395268 - (view) Author: Jeremy Kloth (jkloth) * Date: 2021-06-07 17:07
Currently, a stack overflow is causing the debug build Windows buildbots to abort (bpo-11105).  Once the regrtest process is terminated, the buildbot test process hangs indefinitely waiting for handles to be closed (see msg350191 from bpo-37531 for some details).
msg395269 - (view) Author: Jeremy Kloth (jkloth) * Date: 2021-06-07 17:24
To verify the PR, can someone please add the test-with-buildbots label on GH?
msg395274 - (view) Author: Jeremy Kloth (jkloth) * Date: 2021-06-07 18:46
The PR has been successfully run on the buildbots.

Before:
https://buildbot.python.org/all/#/builders/593/builds/58

After:
https://buildbot.python.org/all/#/builders/593/builds/59

With these changes, at least now aborted runs can be seen as direct failures of Python's tests instead of just builder exceptions.
msg395496 - (view) Author: Jeremy Kloth (jkloth) * Date: 2021-06-10 01:34
While now not as immediately beneficial, I believe that the linked PR would be good for the long run.  The ramifications of bpo-11105 meant that the Windows buildbots were basically unusable for 5 days.

Realistically, any commit that triggers aborts in the Windows test runs will exhibit this problematic behavior.  I'm confident that the PR is in ready-to-go form.
msg415730 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-22 00:07
New changeset 19058b9f6271338bcc46b7d30fe79a83990cc35c by Jeremy Kloth in branch 'main':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/19058b9f6271338bcc46b7d30fe79a83990cc35c
msg415796 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-22 17:21
New changeset 8146e6b636905d9872140c990d93308ac20d13f0 by Jeremy Kloth in branch '3.10':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/8146e6b636905d9872140c990d93308ac20d13f0
msg415797 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-22 17:21
New changeset 8db7610d1a7b1f90631bac26261338f27bd20727 by Jeremy Kloth in branch '3.9':
bpo-44336: Prevent tests hanging on child process handles on Windows (GH-26578)
https://github.com/python/cpython/commit/8db7610d1a7b1f90631bac26261338f27bd20727
msg415798 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2022-03-22 17:21
Thanks!
History
Date User Action Args
2022-04-11 14:59:46adminsetgithub: 88502
2022-03-22 17:36:10jklothsetpull_requests: + pull_request30146
2022-03-22 17:21:55steve.dowersetstatus: open -> closed
resolution: fixed
messages: + msg415798

stage: patch review -> resolved
2022-03-22 17:21:39steve.dowersetmessages: + msg415797
2022-03-22 17:21:32steve.dowersetmessages: + msg415796
2022-03-22 14:31:46jklothsetpull_requests: + pull_request30139
2022-03-22 00:07:03steve.dowersetmessages: + msg415730
2021-06-10 01:34:56jklothsetmessages: + msg395496
2021-06-07 18:46:14jklothsetmessages: + msg395274
2021-06-07 17:24:36jklothsetmessages: + msg395269
2021-06-07 17:16:40jklothsetkeywords: + patch
stage: patch review
pull_requests: + pull_request25166
2021-06-07 17:07:52jklothcreate