This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: [sqlite3] don't use politicians in examples/docs
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.11, Python 3.10, Python 3.9
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: berker.peksag, docs@python, erlendaasland, kj, miss-islington
Priority: normal Keywords: patch

Created on 2021-05-10 22:49 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 26027 merged erlendaasland, 2021-05-10 22:51
PR 26232 merged miss-islington, 2021-05-19 07:41
PR 26233 merged miss-islington, 2021-05-19 07:41
PR 26234 merged erlendaasland, 2021-05-19 07:46
PR 26235 merged miss-islington, 2021-05-19 08:08
PR 26236 merged miss-islington, 2021-05-19 08:08
Messages (7)
msg393439 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-05-10 22:49
In GH-25003, we rewrote one of the database examples to use programming languages iso. political persons. However, there are still some politicians lurking in the sqlite3 docs. Suggesting to get rid of those as well.

See also Berker's comment:
https://github.com/python/cpython/pull/25003#discussion_r613135200
msg393443 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-05-11 07:02
Berker, the following files are not included by Doc/library/sqlite3.rst:

- Doc/includes/sqlite3/countcursors.py
- Doc/includes/sqlite3/createdb.py             # never referenced by docs
- Doc/includes/sqlite3/execsql_fetchonerow.py
- Doc/includes/sqlite3/execsql_printall_1.py
- Doc/includes/sqlite3/parse_colnames.py
- Doc/includes/sqlite3/shared_cache.py
- Doc/includes/sqlite3/simple_tableprinter.py

All but createdb.py were referenced by doc/usage-guide.txt (pysqlite repo), which was deleted by pysqlite commit 64c9600 (2008-03-24) when pysqlite switched to Sphinx documentation.

Can I purge these in PR 26027, or do you want a separate issue/PR for this?
msg393444 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-05-11 07:07
Ditto for Doc/includes/sqlite3/insert_more_people.py
msg393930 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-05-19 07:43
New changeset db20afe6c43ad585577589131bf658ce7ebe6bd2 by Miss Islington (bot) in branch '3.9':
bpo-44106: Improve sqlite3 example database contents (GH-26027)
https://github.com/python/cpython/commit/db20afe6c43ad585577589131bf658ce7ebe6bd2
msg393931 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-05-19 07:44
New changeset 3185bc9d3f38ce9d814aecf8104f1d6953c2d8ff by Miss Islington (bot) in branch '3.10':
bpo-44106: Improve sqlite3 example database contents (GH-26027)
https://github.com/python/cpython/commit/3185bc9d3f38ce9d814aecf8104f1d6953c2d8ff
msg393934 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-05-19 08:17
New changeset 5b5a10c8740aa5e9fd68a10d9cb23b0e7d61ce98 by Miss Islington (bot) in branch '3.9':
bpo-44106: Purge unused sqlite3 doc includes (GH-26234)
https://github.com/python/cpython/commit/5b5a10c8740aa5e9fd68a10d9cb23b0e7d61ce98
msg393935 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-05-19 08:17
New changeset e57bef1b73abb8e89d927053bd7e4fdbf44687bf by Miss Islington (bot) in branch '3.10':
bpo-44106: Purge unused sqlite3 doc includes (GH-26234)
https://github.com/python/cpython/commit/e57bef1b73abb8e89d927053bd7e4fdbf44687bf
History
Date User Action Args
2022-04-11 14:59:45adminsetgithub: 88272
2021-05-19 08:27:43erlendaaslandsetstatus: open -> closed
resolution: fixed
stage: patch review -> resolved
2021-05-19 08:17:22berker.peksagsetmessages: + msg393935
2021-05-19 08:17:13berker.peksagsetmessages: + msg393934
2021-05-19 08:08:25miss-islingtonsetpull_requests: + pull_request24853
2021-05-19 08:08:20miss-islingtonsetpull_requests: + pull_request24852
2021-05-19 07:46:28erlendaaslandsetpull_requests: + pull_request24851
2021-05-19 07:44:06berker.peksagsetmessages: + msg393931
2021-05-19 07:43:52berker.peksagsetmessages: + msg393930
2021-05-19 07:41:32miss-islingtonsetpull_requests: + pull_request24850
2021-05-19 07:41:27miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request24849
2021-05-11 07:07:28erlendaaslandsetmessages: + msg393444
2021-05-11 07:02:53erlendaaslandsetmessages: + msg393443
2021-05-10 22:51:33erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request24677
2021-05-10 22:49:10erlendaaslandcreate