➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2021-04-15 10:00 by erlendaasland, last changed 2022-04-11 14:59 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch.diff | erlendaasland, 2021-04-15 10:00 | |||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 25422 | merged | erlendaasland, 2021-04-15 10:04 | |
| PR 26534 | merged | miss-islington, 2021-06-04 18:34 | |
| PR 27627 | merged | erlendaasland, 2021-08-06 12:39 | |
| PR 27642 | merged | erlendaasland, 2021-08-06 19:43 | |
| PR 27922 | merged | erlendaasland, 2021-08-23 20:06 | |
| PR 27952 | merged | erlendaasland, 2021-08-25 19:13 | |
| PR 27953 | merged | erlendaasland, 2021-08-25 19:18 | |
| PR 31030 | merged | erlendaasland, 2022-01-30 20:00 | |
| PR 31586 | merged | erlendaasland, 2022-02-25 15:34 | |
| Messages (17) | |||
|---|---|---|---|
| msg391124 - (view) | Author: Erlend E. Aasland (erlendaasland) *  |
Date: 2021-04-15 10:00 | |
Fix sqlite3_value_text() usage: - Raise MemoryError if sqlite3_value_text() sets SQLITE_NOMEM - Let PyUnicode_FromStringAndSize() errors propagate Quoting the SQLite docs: "As long as the input parameter is correct, these routines can only fail if an out-of-memory error occurs" See also: - bpo-43296 - https://sqlite.org/c3ref/value_blob.html |
|||
| msg394267 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-05-24 20:53 | |
The affected branch is exercised by the following tests: - test_aggr_check_param_blob - test_aggr_check_param_float - test_aggr_check_param_int - test_aggr_check_param_none - test_aggr_check_param_str - test_aggr_check_params_int - test_aggr_exception_in_finalize - test_aggr_exception_in_step - test_aggr_no_finalize - test_param_string I've expanded test_aggr_check_param_str and test_param_string to also check empty strings. |
|||
| msg395109 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2021-06-04 18:34 | |
New changeset 006fd869e4798b68e266f5de89c83ddb531a756b by Erlend Egeberg Aasland in branch 'main': bpo-43853: Handle sqlite3_value_text() errors (GH-25422) https://github.com/python/cpython/commit/006fd869e4798b68e266f5de89c83ddb531a756b |
|||
| msg395112 - (view) | Author: miss-islington (miss-islington) | Date: 2021-06-04 18:54 | |
New changeset 067d6d46575b5cf30bbf7c812defee1517106a34 by Miss Islington (bot) in branch '3.10': bpo-43853: Handle sqlite3_value_text() errors (GH-25422) https://github.com/python/cpython/commit/067d6d46575b5cf30bbf7c812defee1517106a34 |
|||
| msg399075 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-08-06 11:53 | |
I think it is worth to backport it to 3.9. It looks to me that it fixes also support of strings containing NUL. It would be nice to add corresponding tests for this. You can also add this in the NEWS entry for this issue. |
|||
| msg399084 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-08-06 12:58 | |
I'll add extra tests in a separate PR, so we can easily backport it to 3.10 and 3.9. |
|||
| msg399114 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-08-06 17:57 | |
New changeset 8c07fef867707694c9f2fcee4d7a9563ad78ed14 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Handle sqlite3_value_text() errors (GH-25422). (GH-27627) https://github.com/python/cpython/commit/8c07fef867707694c9f2fcee4d7a9563ad78ed14 |
|||
| msg399120 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2021-08-06 18:26 | |
What about new tests and NEWS update? |
|||
| msg400174 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-08-23 20:09 | |
> What about new tests and NEWS update? See PR 27642 for the expanded tests, and PR 27922 for amending news entries. I didn't combine the two, as I figured you might have more comments on the former PR. |
|||
| msg400288 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2021-08-25 19:03 | |
New changeset 7903a1096343d8018e889029f025d39bdd077170 by Erlend Egeberg Aasland in branch 'main': bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) https://github.com/python/cpython/commit/7903a1096343d8018e889029f025d39bdd077170 |
|||
| msg400292 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2021-08-25 19:26 | |
New changeset 0ec17a2494412ea7d76f7d0567b73c1fffa88c18 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922) (GH-27952) https://github.com/python/cpython/commit/0ec17a2494412ea7d76f7d0567b73c1fffa88c18 |
|||
| msg400296 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2021-08-25 19:50 | |
New changeset b34ca7e0515e6726cf5e938f7239de41df710cfd by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-43853: Amend NEWS entry for latest changes in sqlite3 (GH-27922). (GH-27953) https://github.com/python/cpython/commit/b34ca7e0515e6726cf5e938f7239de41df710cfd |
|||
| msg400319 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-08-26 07:08 | |
Thanks for merging the NEWS amendments, Pablo. We can close this issue after landing PR 27642. |
|||
| msg401565 - (view) | Author: Erlend E. Aasland (erlendaasland) * |
Date: 2021-09-10 08:55 | |
Serhiy, I believe I've addressed your review remarks on PR 27642. Would you mind taking a look at it again if you have time? |
|||
| msg411771 - (view) | Author: Guido van Rossum (gvanrossum) * |
Date: 2022-01-26 16:26 | |
New changeset 3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b by Erlend Egeberg Aasland in branch 'main': bpo-43853: Expand test suite for SQLite UDF's (GH-27642) https://github.com/python/cpython/commit/3eb3b4f270757f66c7fb6dcf5afa416ee1582a4b |
|||
| msg413620 - (view) | Author: Jelle Zijlstra (JelleZijlstra) * |
Date: 2022-02-21 00:13 | |
New changeset ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 by Erlend Egeberg Aasland in branch '3.10': [3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) https://github.com/python/cpython/commit/ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 |
|||
| msg414325 - (view) | Author: miss-islington (miss-islington) | Date: 2022-03-02 04:46 | |
New changeset 3ea2a8f425d26e81d914c54d477e9d56eb27ac98 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030) (GH-31586) https://github.com/python/cpython/commit/3ea2a8f425d26e81d914c54d477e9d56eb27ac98 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:59:44 | admin | set | github: 88019 |
| 2022-03-02 06:41:01 | erlendaasland | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2022-03-02 04:46:20 | miss-islington | set | messages: + msg414325 |
| 2022-02-25 15:34:45 | erlendaasland | set | pull_requests: + pull_request29709 |
| 2022-02-21 00:13:13 | JelleZijlstra | set | nosy:
+ JelleZijlstra messages: + msg413620 |
| 2022-01-30 20:00:15 | erlendaasland | set | pull_requests: + pull_request29211 |
| 2022-01-26 16:26:26 | gvanrossum | set | nosy:
+ gvanrossum messages: + msg411771 |
| 2021-09-10 08:55:22 | erlendaasland | set | messages: + msg401565 |
| 2021-08-26 07:08:04 | erlendaasland | set | messages: + msg400319 |
| 2021-08-25 19:50:28 | pablogsal | set | messages: + msg400296 |
| 2021-08-25 19:26:37 | pablogsal | set | messages: + msg400292 |
| 2021-08-25 19:18:39 | erlendaasland | set | pull_requests: + pull_request26400 |
| 2021-08-25 19:13:35 | erlendaasland | set | pull_requests: + pull_request26399 |
| 2021-08-25 19:03:15 | pablogsal | set | messages: + msg400288 |
| 2021-08-23 20:09:35 | erlendaasland | set | messages: + msg400174 |
| 2021-08-23 20:07:16 | erlendaasland | set | messages: - msg399133 |
| 2021-08-23 20:06:34 | erlendaasland | set | pull_requests: + pull_request26374 |
| 2021-08-06 19:43:18 | erlendaasland | set | stage: resolved -> patch review pull_requests: + pull_request26136 |
| 2021-08-06 19:24:15 | erlendaasland | set | messages: + msg399133 |
| 2021-08-06 18:28:27 | erlendaasland | set | status: closed -> open resolution: fixed -> (no value) |
| 2021-08-06 18:26:57 | serhiy.storchaka | set | messages: + msg399120 |
| 2021-08-06 18:07:16 | erlendaasland | set | status: open -> closed stage: patch review -> resolved |
| 2021-08-06 17:57:46 | serhiy.storchaka | set | messages: + msg399114 |
| 2021-08-06 12:58:27 | erlendaasland | set | messages: + msg399084 |
| 2021-08-06 12:39:05 | erlendaasland | set | stage: resolved -> patch review pull_requests: + pull_request26121 |
| 2021-08-06 11:53:34 | serhiy.storchaka | set | status: closed -> open messages: + msg399075 versions: + Python 3.9, Python 3.11 |
| 2021-06-04 18:54:57 | miss-islington | set | messages: + msg395112 |
| 2021-06-04 18:39:12 | pablogsal | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2021-06-04 18:34:27 | miss-islington | set | nosy:
+ miss-islington pull_requests: + pull_request25125 |
| 2021-06-04 18:34:07 | pablogsal | set | nosy:
+ pablogsal messages: + msg395109 |
| 2021-05-24 20:53:17 | erlendaasland | set | messages: + msg394267 |
| 2021-05-09 17:05:28 | erlendaasland | set | title: [sqlite3] Fix sqlite3_value_text() usage -> [sqlite3] Improve sqlite3_value_text() error handling |
| 2021-04-15 10:04:35 | erlendaasland | set | title: [sqlite] Fix sqlite3_value_text() usage -> [sqlite3] Fix sqlite3_value_text() usage |
| 2021-04-15 10:04:10 | erlendaasland | set | stage: patch review pull_requests: + pull_request24154 |
| 2021-04-15 10:00:09 | erlendaasland | create | |