classification
Title: [sqlite3] Move MODULE_NAME def from setup.py to module.h
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, erlendaasland
Priority: normal Keywords: patch

Created on 2021-03-09 10:34 by erlendaasland, last changed 2021-03-13 15:34 by berker.peksag. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 24801 merged erlendaasland, 2021-03-09 13:22
Messages (3)
msg388344 - (view) Author: Erlend E. Aasland (erlendaasland) * (Python triager) Date: 2021-03-09 10:34
Berker, can we please move the MODULE_NAME define from setup.py to Modules/_sqlite/module.h? I'm tired of all the undeclared identifier warnings. No other module defines their MODULE_NAME in setup.py.
msg388623 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-03-13 15:33
New changeset 2256a2876b5214a5a7492bf78bd86cf8beb690bf by Erlend Egeberg Aasland in branch 'master':
bpo-43444: Move sqlite3 MODULE_NAME from setup.py to module.h (GH-24801)
https://github.com/python/cpython/commit/2256a2876b5214a5a7492bf78bd86cf8beb690bf
msg388624 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2021-03-13 15:34
Thank you!
History
Date User Action Args
2021-03-13 15:34:03berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg388624

stage: patch review -> resolved
2021-03-13 15:33:46berker.peksagsetmessages: + msg388623
2021-03-09 13:22:56erlendaaslandsetkeywords: + patch
stage: patch review
pull_requests: + pull_request23569
2021-03-09 10:34:19erlendaaslandcreate