classification
Title: test_importlib failure due to missing skip() method
Type: behavior Stage: patch review
Components: Tests Versions:
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: miss-islington, nascheme
Priority: normal Keywords: patch

Created on 2021-02-21 19:04 by nascheme, last changed 2021-02-21 23:24 by nascheme.

Pull Requests
URL Status Linked Edit
PR 24612 merged nascheme, 2021-02-21 19:18
PR 24613 open miss-islington, 2021-02-21 21:48
PR 24614 merged nascheme, 2021-02-21 21:54
PR 24616 merged nascheme, 2021-02-21 22:34
Messages (4)
msg387471 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2021-02-21 19:04
The FileSystem class is missing a skip() method.  If the file system doesn't support Unicode filenames, the test crashes.

  File "/home/nas/src/cpython/Lib/test/test_importlib/fixtures.py", line 221, in unicode_filename
    self.skip("File system does not support non-ascii.")
AttributeError: 'FileSystem' object has no attribute 'skip'

I'm running tests inside a Debian 32-bit container and for some reason the test.support.FS_NONASCII variable is not set.
msg387473 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2021-02-21 21:48
New changeset 50288aa8c955f66ab67a7dadf250ea5f4238eb67 by Neil Schemenauer in branch 'master':
bpo-43288: Fix bug in test_importlib test. (GH-24612)
https://github.com/python/cpython/commit/50288aa8c955f66ab67a7dadf250ea5f4238eb67
msg387475 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2021-02-21 22:22
New changeset 84f7afe65c29330f3ff8e318e054b96554a2dede by Neil Schemenauer in branch 'master':
Fix failed merge of bpo-43288. (GH-24614)
https://github.com/python/cpython/commit/84f7afe65c29330f3ff8e318e054b96554a2dede
msg387479 - (view) Author: Neil Schemenauer (nascheme) * (Python committer) Date: 2021-02-21 23:24
New changeset 44fe32061d60f4bd9c4fa48c24e3e4ba26033dba by Neil Schemenauer in branch '3.9':
[3.9] bpo-43288: Fix bug in test_importlib test. (GH-24616)
https://github.com/python/cpython/commit/44fe32061d60f4bd9c4fa48c24e3e4ba26033dba
History
Date User Action Args
2021-02-21 23:24:49naschemesetmessages: + msg387479
2021-02-21 22:34:00naschemesetpull_requests: + pull_request23397
2021-02-21 22:22:21naschemesetmessages: + msg387475
2021-02-21 21:54:57naschemesetpull_requests: + pull_request23395
2021-02-21 21:48:36miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request23394
2021-02-21 21:48:25naschemesetmessages: + msg387473
2021-02-21 19:18:23naschemesetkeywords: + patch
stage: patch review
pull_requests: + pull_request23391
2021-02-21 19:04:37naschemecreate