classification
Title: Some configure checks rely on implicit function declaration
Type: compile error Stage: resolved
Components: Build Versions: Python 3.10, Python 3.9, Python 3.8
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: jmr, miss-islington, ned.deily
Priority: normal Keywords: patch

Created on 2020-12-08 11:15 by jmr, last changed 2020-12-13 22:04 by ned.deily. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23690 merged jmr, 2020-12-08 11:17
PR 23756 merged miss-islington, 2020-12-13 21:09
PR 23757 merged miss-islington, 2020-12-13 21:42
Messages (5)
msg382726 - (view) Author: Joshua Root (jmr) * Date: 2020-12-08 11:15
There are several cases in the configure script of exit being used without including stdlib.h, and one case of close being used without including unistd.h. A compiler that does not allow implicit function declaration, such as clang in Xcode 12, will error out due to this, which may cause the affected checks to give incorrect results.
msg382940 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-12-13 20:56
New changeset 674fa0a740151e0416c9383f127b16014e805990 by Joshua Root in branch 'master':
bpo-42598: Fix implicit function declarations in configure (GH-23690)
https://github.com/python/cpython/commit/674fa0a740151e0416c9383f127b16014e805990
msg382941 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-12-13 22:01
New changeset 3dcdbdeb4833e45430ccc9cb3432f779a6fd8c94 by Miss Islington (bot) in branch '3.9':
bpo-42598: Fix implicit function declarations in configure (GH-23690) (GH-23756)
https://github.com/python/cpython/commit/3dcdbdeb4833e45430ccc9cb3432f779a6fd8c94
msg382942 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-12-13 22:02
New changeset 9feda9f871498463fe502d63204cf9cd6c1f4706 by Miss Islington (bot) in branch '3.8':
bpo-42598: Fix implicit function declarations in configure (GH-23690) (GH-23757)
https://github.com/python/cpython/commit/9feda9f871498463fe502d63204cf9cd6c1f4706
msg382943 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2020-12-13 22:04
Thanks for noticing the failures and for the PR!
History
Date User Action Args
2020-12-13 22:04:41ned.deilysetstatus: open -> closed
versions: + Python 3.8
messages: + msg382943

resolution: fixed
stage: patch review -> resolved
2020-12-13 22:02:02ned.deilysetmessages: + msg382942
2020-12-13 22:01:08ned.deilysetmessages: + msg382941
2020-12-13 21:42:16miss-islingtonsetpull_requests: + pull_request22613
2020-12-13 21:09:48miss-islingtonsetnosy: + miss-islington
pull_requests: + pull_request22612
2020-12-13 20:56:38ned.deilysetnosy: + ned.deily
messages: + msg382940
2020-12-08 11:17:35jmrsetkeywords: + patch
stage: patch review
pull_requests: + pull_request22558
2020-12-08 11:15:17jmrcreate