classification
Title: Cleanup importlib code
Type: Stage: resolved
Components: Library (Lib) Versions: Python 3.10
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: vstinner
Priority: normal Keywords: patch

Created on 2020-11-19 08:37 by vstinner, last changed 2020-11-20 13:56 by vstinner. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 23395 merged vstinner, 2020-11-19 09:41
PR 23396 merged vstinner, 2020-11-19 09:43
PR 23397 merged vstinner, 2020-11-19 10:39
Messages (5)
msg381397 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-19 08:37
Placeholder issuer to enhance the importlib code base and "bootstrap" code.
msg381401 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-19 10:21
New changeset 7d9d25dbedfffce61fc76bc7ccbfa9ae901bf56f by Victor Stinner in branch 'master':
bpo-42403: Fix pyflakes warnings in importlib (GH-23396)
https://github.com/python/cpython/commit/7d9d25dbedfffce61fc76bc7ccbfa9ae901bf56f
msg381408 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-19 12:43
New changeset 3390347aa036404453213d589fe1e35902e55fd4 by Victor Stinner in branch 'master':
bpo-42403: Simplify importlib external bootstrap (GH-23397)
https://github.com/python/cpython/commit/3390347aa036404453213d589fe1e35902e55fd4
msg381479 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-20 13:44
New changeset 3be8e220ede7764a403b74eb2051aa703dde2626 by Victor Stinner in branch 'master':
bpo-42403: Use @staticmethod in importlib (GH-23395)
https://github.com/python/cpython/commit/3be8e220ede7764a403b74eb2051aa703dde2626
msg381480 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2020-11-20 13:56
I tried to rework how importlib/_bootstrap.py is imported and rework importlib/__init__.py code which imports _bootstrap.py and _bootstrap_external.py, but I introduced bugs. I prefer to leave the code as it is.

At least, _bootstrap_external.py is now able to use regular imports (for builtin modules) rather than requiring to inject modules afterwards.
History
Date User Action Args
2020-11-20 13:56:06vstinnersetstatus: open -> closed
resolution: fixed
messages: + msg381480

stage: patch review -> resolved
2020-11-20 13:44:07vstinnersetmessages: + msg381479
2020-11-19 12:43:46vstinnersetmessages: + msg381408
2020-11-19 10:39:51vstinnersetpull_requests: + pull_request22289
2020-11-19 10:21:02vstinnersetmessages: + msg381401
2020-11-19 09:43:11vstinnersetpull_requests: + pull_request22288
2020-11-19 09:41:28vstinnersetkeywords: + patch
stage: patch review
pull_requests: + pull_request22287
2020-11-19 08:37:24vstinnercreate